<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left">
[AMD Official Use Only - General]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof">
<br>
</div>
<div id="divRplyFwdMsg" dir="ltr" class="elementToProof"><font face="Calibri, sans-serif" style="font-size: 11pt; color: rgb(0, 0, 0);"><b>From:</b> Limonciello, Mario <Mario.Limonciello@amd.com><br>
</font></div>
<div dir="ltr"><font face="Calibri, sans-serif" style="font-size: 11pt; color: rgb(0, 0, 0);"><b>Sent:</b> Friday, July 28, 2023 9:14 AM<br>
<b>To:</b> Huang, Tim <Tim.Huang@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Deucher, Alexander <Alexander.Deucher@amd.com>; Zhang, Yifan <Yifan1.Zhang@amd.com><br>
<b>Subject:</b> Re: [PATCH] drm/amd/pm: skip the RLC stop when S0i3 suspend for SMU v13.0.4/11</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText elementToProof">On 7/27/23 20:05, Tim Huang wrote:<br>
> From: Tim Huang <Tim.Huang@amd.com><br>
><br>
> For SMU v13.0.4/11, driver does not need to stop RLC for S0i3,<br>
> the firmwares will handle that properly.<br>
> Conceptually I'm aligned to this.<br>
</div>
<div class="PlainText elementToProof">> But, just to confirm, have you already run some testing with this<br>
</div>
<div class="PlainText elementToProof"><span style="font-family: "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; display: inline !important; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="ContentPasted6">> </span>with
current GPU F/W, BIOS and either 6.1.y, 6.4.y or ASDN?<br>
<br>
<span style="font-family: "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; display: inline !important; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="ContentPasted3">> </span>I
checked with this on my side and saw success but I'm fearful<br>
<span style="font-family: "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; display: inline !important; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="ContentPasted4">> </span>that
it introduces some of the fence expiration problems we<br>
<span style="font-family: "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; display: inline !important; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="ContentPasted5">> </span>had
in the past and I'm just not seeing them for some reason.</div>
<div class="PlainText elementToProof"><br>
</div>
<div class="PlainText elementToProof"><span class="PlainText" style="font-family: "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; margin: 0px; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"><span class="PlainText ContentPasted0" style="margin: 0px; background-color: rgb(255, 255, 255);">Yes,
verified based on current BIOS and latest drm-next kernel and the working FWs as the latest FWs </span></span>
<div class="PlainText" style="font-family: "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; margin: 0px; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);">
<span class="PlainText" style="margin: 0px; background-color: rgb(255, 255, 255);"><span class="ContentPasted0" style="margin:0px">may have some new issues. </span></span></div>
<div class="PlainText ContentPasted0" style="font-family: "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; margin: 0px; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);">
</div>
<div class="PlainText ContentPasted0" style="font-family: "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; margin: 0px; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);">
For this patch, it is asked by the FW guys, <span style="margin:0px"><span class="ui-provider fy b c d e f g h i j k l m n o p q r s t u v w x y z ab ac ae af ag ah ai aj ak ContentPasted1 ContentPasted0" dir="ltr" style="margin:0px">driver should not touch
RLC_CNTL in S0i3, let RLC FW to do that. If driver programs RLC_CNTL to halt RLC, RLC cannot go GFXOFF exit sequence. </span></span></div>
<div class="PlainText" style="font-family: "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; margin: 0px; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);">
<span style="margin:0px"><span class="ui-provider fy b c d e f g h i j k l m n o p q r s t u v w x y z ab ac ae af ag ah ai aj ak ContentPasted1" dir="ltr" style="margin:0px"><br class="ContentPasted0">
</span></span></div>
<div class="PlainText" style="font-family: "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; margin: 0px; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);">
<span style="margin:0px"><span class="ui-provider fy b c d e f g h i j k l m n o p q r s t u v w x y z ab ac ae af ag ah ai aj ak ContentPasted1 ContentPasted0" dir="ltr" style="margin:0px">The fence expiration should be still there by the delayed GFXOFF ,
but this patch should be useful to help debug it as it avoids the system hang when the issue happens. </span></span></div>
<div class="PlainText" style="font-family: "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; margin: 0px; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);">
<br class="ContentPasted0">
</div>
<div class="PlainText" style="font-family: "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; margin: 0px; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);">
<span style="margin:0px"><span class="ui-provider fy b c d e f g h i j k l m n o p q r s t u v w x y z ab ac ae af ag ah ai aj ak ContentPasted1 ContentPasted0" dir="ltr" style="margin:0px">Best Regards,<br class="ContentPasted0">
<span style="margin:0px" class="ContentPasted0">Tim</span></span></span></div>
<br>
><br>
> Signed-off-by: Tim Huang <Tim.Huang@amd.com><br>
> ---<br>
> drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 4 ++--<br>
> 1 file changed, 2 insertions(+), 2 deletions(-)<br>
><br>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c<br>
> index ce41a8309582..222af2fae745 100644<br>
> --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c<br>
> +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c<br>
> @@ -1581,9 +1581,9 @@ static int smu_disable_dpms(struct smu_context *smu)<br>
> <br>
> /*<br>
> * For SMU 13.0.4/11, PMFW will handle the features disablement properly<br>
> - * for gpu reset case. Driver involvement is unnecessary.<br>
> + * for gpu reset and S0i3 cases. Driver involvement is unnecessary.<br>
> */<br>
> - if (amdgpu_in_reset(adev)) {<br>
> + if (amdgpu_in_reset(adev) || adev->in_s0ix) {<br>
> switch (adev->ip_versions[MP1_HWIP][0]) {<br>
> case IP_VERSION(13, 0, 4):<br>
> case IP_VERSION(13, 0, 11):<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>