<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word"> [AMD Official Use Only - General] <div> <div class="WordSection1"> Hi Michel,<o:p></o:p> <o:p> </o:p> Could you try the patch again ? That work for me.<o:p></o:p> <a href="https://patchwork.freedesktop.org/patch/549605/">https://patchwork.freedesktop.org/patch/549605/</a><o:p></o:p> <o:p> </o:p> Thanks<o:p></o:p> Jesse<o:p></o:p> <o:p> </o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm"> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Zhang, Jesse(Jie) Sent: Thursday, July 27, 2023 2:11 PM To: Yang, Philip <Philip.Yang@amd.com>; Michel Dänzer <michel@daenzer.net>; Yang, Philip <Philip.Yang@amd.com> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Kuehling, Felix <Felix.Kuehling@amd.com>; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 28/29] drm/amdkfd: Refactor migrate init to support partition switch<o:p></o:p> </div> </div> <o:p> </o:p> [AMD Official Use Only - General]<o:p></o:p> <o:p> </o:p> <div> [AMD Official Use Only - General]<o:p></o:p> <o:p> </o:p> <div> Hi Philip and Michel,<o:p></o:p> <o:p> </o:p> The following issue can reproduce on my side. <o:p></o:p> <a href="https://gitlab.freedesktop.org/drm/amd/-/issues/2659">https://gitlab.freedesktop.org/drm/amd/-/issues/2659</a><o:p></o:p> <o:p> </o:p> when load gpu driver , disable iommu can workaround this issue.<o:p></o:p> sudo modprobe amdgpu ignore_crat=1<o:p></o:p> <o:p> </o:p> Thanks<o:p></o:p> Jesse<o:p></o:p> <o:p> </o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm"> From: amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">amd-gfx-bounces@lists.freedesktop.org</a>> On Behalf Of Philip Yang Sent: Tuesday, July 25, 2023 4:04 AM To: Michel Dänzer <<a href="mailto:michel@daenzer.net">michel@daenzer.net</a>>; Yang, Philip <<a href="mailto:Philip.Yang@amd.com">Philip.Yang@amd.com</a>> Cc: Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com">Alexander.Deucher@amd.com</a>>; Kuehling, Felix <<a href="mailto:Felix.Kuehling@amd.com">Felix.Kuehling@amd.com</a>>; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> Subject: Re: [PATCH 28/29] drm/amdkfd: Refactor migrate init to support partition switch<o:p></o:p> </div> </div> <o:p> </o:p> Hi Michel,<o:p></o:p> Please check if this patch "drm/amdkfd: start_cpsch don't map queues" can fix the driver loading ring test failed issue on your system, I am still not able to repro the issue.<o:p></o:p> Regards,<o:p></o:p> Philip<o:p></o:p> <div> On 2023-07-21 09:30, Philip Yang wrote:<o:p></o:p> </div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <o:p> </o:p> <div> On 2023-07-21 04:55, Michel Dänzer wrote:<o:p></o:p> </div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <pre>On 7/20/23 22:48, Philip Yang wrote:<o:p></o:p></pre> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <pre>On 2023-07-20 06:46, Michel Dänzer wrote:<o:p></o:p></pre> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <pre>On 7/17/23 15:09, Michel Dänzer wrote:<o:p></o:p></pre> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <pre>On 5/10/23 23:23, Alex Deucher wrote:<o:p></o:p></pre> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <pre>From: Philip Yang <a href="mailto:Philip.Yang@amd.com"><Philip.Yang@amd.com></a><o:p></o:p></pre> <pre><o:p> </o:p></pre> <pre>Rename smv_migrate_init to a better name kgd2kfd_init_zone_device<o:p></o:p></pre> <pre>because it setup zone devive pgmap for page migration and keep it in<o:p></o:p></pre> <pre>kfd_migrate.c to access static functions svm_migrate_pgmap_ops. Call it<o:p></o:p></pre> <pre>only once in amdgpu_device_ip_init after adev ip blocks are initialized,<o:p></o:p></pre> <pre>but before amdgpu_amdkfd_device_init initialize kfd nodes which enable<o:p></o:p></pre> <pre>SVM support based on pgmap.<o:p></o:p></pre> <pre><o:p> </o:p></pre> <pre>svm_range_set_max_pages is called by kgd2kfd_device_init everytime after<o:p></o:p></pre> <pre>switching compute partition mode.<o:p></o:p></pre> <pre><o:p> </o:p></pre> <pre>Signed-off-by: Philip Yang <a href="mailto:Philip.Yang@amd.com"><Philip.Yang@amd.com></a><o:p></o:p></pre> <pre>Reviewed-by: Felix Kuehling <a href="mailto:Felix.Kuehling@amd.com"><Felix.Kuehling@amd.com></a><o:p></o:p></pre> <pre>Signed-off-by: Alex Deucher <a href="mailto:alexander.deucher@amd.com"><alexander.deucher@amd.com></a><o:p></o:p></pre> </blockquote> <pre>I bisected a regression to this commit, which broke HW acceleration on this ThinkPad E595 with Picasso APU.<o:p></o:p></pre> </blockquote> <pre>Actually, it doesn't seem to break HW acceleration completely. GDM eventually comes up with HW acceleration, it takes a long time (~30s or so) to start up though.<o:p></o:p></pre> <pre><o:p> </o:p></pre> <pre>Later, the same messages as described in <a href="https://gitlab.freedesktop.org/drm/amd/-/issues/2659">https://gitlab.freedesktop.org/drm/amd/-/issues/2659</a> appear.<o:p></o:p></pre> <pre><o:p> </o:p></pre> <pre>Reverting this commit fixes all of the above symptoms.<o:p></o:p></pre> <pre><o:p> </o:p></pre> <pre><o:p> </o:p></pre> <pre>I reproduced all of the above symptoms with amd-staging-drm-next commit 75515acf4b60 ("i2c: nvidia-gpu: Add ACPI property to align with device-tree") as well.<o:p></o:p></pre> <pre><o:p> </o:p></pre> <pre><o:p> </o:p></pre> <pre>For full disclosure, I use these kernel command line arguments:<o:p></o:p></pre> <pre><o:p> </o:p></pre> <pre> fbcon=font:10x18 drm_kms_helper.drm_fbdev_overalloc=112 amdgpu.noretry=1 amdgpu.mcbp=1<o:p></o:p></pre> </blockquote> <pre>Thanks for the issue report and full disclosure, but I am not able to reproduce this issue, with both drm-next branch and amd-staging-drm-next branch tip on gitlab. The test system has same device id, running Ubuntu 22.04, latest linux-firmware-20230625.tar.gz, and same BIOS version.<o:p></o:p></pre> </blockquote> <pre>FWIW, your system has PCI revision ID 0xC2, while mine has 0xC1.<o:p></o:p></pre> <pre><o:p> </o:p></pre> <pre>Also, I'm currently using linux-firmware 20230515. AFAICT there are no relevant changes in 20230625, but I'm attaching the contents of /sys/kernel/debug/dri/0/amdgpu_firmware_info just in case.<o:p></o:p></pre> <pre><o:p> </o:p></pre> <pre><o:p> </o:p></pre> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <pre>I attached full dmesg log, could you help check if there is other difference, maybe kernel config, gcc version... it is hard to guess what could cause the basic driver gfx ring IB test timeout.<o:p></o:p></pre> </blockquote> <pre>I suspect the IOMMU page faults logged in my dmesg might be relevant:<o:p></o:p></pre> <pre><o:p> </o:p></pre> <pre> amdgpu: Topology: Add APU node [0x15d8:0x1002]<o:p></o:p></pre> <pre> amdgpu 0000:05:00.0: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x0000 address=0x122201800 flags=0x0070]<o:p></o:p></pre> <pre> amdgpu 0000:05:00.0: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x0000 address=0x1125fe380 flags=0x0070]<o:p></o:p></pre> <pre> kfd kfd: amdgpu: added device 1002:15d8<o:p></o:p></pre> <pre><o:p> </o:p></pre> <pre>There are no such page faults with the commit reverted.<o:p></o:p></pre> <pre><o:p> </o:p></pre> <pre>Other than that and the IB test failure messages, our dmesg outputs are mostly identical indeed.<o:p></o:p></pre> </blockquote> Yes, I don't have IO_PAGE_FAULT message on my system, thanks for the finding, I will continue investigating the root cause. <o:p></o:p> You are right, the error message could cause gfx ring IB test timeout failure, this patch does change the order of driver memory allocation. IOMMU is in translation mode on Ubuntu config.<o:p></o:p> To help confirm if this is caused by IOMMU, please add this to kernel boot option to set IOMMU to passthrough mode, check if this can workaround the issue<o:p></o:p> iommu=pt<o:p></o:p> Regards,<o:p></o:p> Philip<o:p></o:p> </blockquote> </div> </div> </div> </div> </body> </html>