<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left">
[AMD Official Use Only - General]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Hi Stylon,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Sorry, the title is misleading. This doesn't touch display. Could you please remove display from the title and make it drm/amd:
<br>
</div>
<div class="elementToProof">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="Signature">
<div>
<div></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
--</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Regards,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Jay<br>
</div>
</div>
</div>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Wang, Chao-kai (Stylon) <Stylon.Wang@amd.com><br>
<b>Sent:</b> Wednesday, August 9, 2023 11:05 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Wentland, Harry <Harry.Wentland@amd.com>; Li, Sun peng (Leo) <Sunpeng.Li@amd.com>; Lakha, Bhawanpreet <Bhawanpreet.Lakha@amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; Pillai, Aurabindo <Aurabindo.Pillai@amd.com>; Zhuo, Qingqing (Lillian)
<Qingqing.Zhuo@amd.com>; Li, Roman <Roman.Li@amd.com>; Lin, Wayne <Wayne.Lin@amd.com>; Wang, Chao-kai (Stylon) <Stylon.Wang@amd.com>; Chiu, Solomon <Solomon.Chiu@amd.com>; Kotarac, Pavle <Pavle.Kotarac@amd.com>; Gutierrez, Agustin <Agustin.Gutierrez@amd.com>;
Pillai, Aurabindo <Aurabindo.Pillai@amd.com><br>
<b>Subject:</b> [PATCH 13/15] drm/amd/display: Remove freesync video mode amdgpu parameter</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">From: Aurabindo Pillai <aurabindo.pillai@amd.com><br>
<br>
[Why&How]<br>
Freesync Video mode was enabled by default. Hence no need for the module<br>
parameter, so remove it completely<br>
<br>
Acked-by: Stylon Wang <stylon.wang@amd.com><br>
Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com><br>
Reviewed-by: Stylon Wang <stylon.wang@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 -<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 27 -------------------------<br>
2 files changed, 28 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h<br>
index 2e3c7c15cb8e..4de074243c4d 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h<br>
@@ -193,7 +193,6 @@ extern int amdgpu_emu_mode;<br>
extern uint amdgpu_smu_memory_pool_size;<br>
extern int amdgpu_smu_pptable_id;<br>
extern uint amdgpu_dc_feature_mask;<br>
-extern uint amdgpu_freesync_vid_mode;<br>
extern uint amdgpu_dc_debug_mask;<br>
extern uint amdgpu_dc_visual_confirm;<br>
extern uint amdgpu_dm_abm_level;<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c<br>
index 0fec81d6a7df..8f7d0f8e57ae 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c<br>
@@ -187,7 +187,6 @@ int amdgpu_mes_kiq;<br>
int amdgpu_noretry = -1;<br>
int amdgpu_force_asic_type = -1;<br>
int amdgpu_tmz = -1; /* auto */<br>
-uint amdgpu_freesync_vid_mode;<br>
int amdgpu_reset_method = -1; /* auto */<br>
int amdgpu_num_kcq = -1;<br>
int amdgpu_smartshift_bias;<br>
@@ -885,32 +884,6 @@ module_param_named(backlight, amdgpu_backlight, bint, 0444);<br>
MODULE_PARM_DESC(tmz, "Enable TMZ feature (-1 = auto (default), 0 = off, 1 = on)");<br>
module_param_named(tmz, amdgpu_tmz, int, 0444);<br>
<br>
-/**<br>
- * DOC: freesync_video (uint)<br>
- * Enable the optimization to adjust front porch timing to achieve seamless<br>
- * mode change experience when setting a freesync supported mode for which full<br>
- * modeset is not needed.<br>
- *<br>
- * The Display Core will add a set of modes derived from the base FreeSync<br>
- * video mode into the corresponding connector's mode list based on commonly<br>
- * used refresh rates and VRR range of the connected display, when users enable<br>
- * this feature. From the userspace perspective, they can see a seamless mode<br>
- * change experience when the change between different refresh rates under the<br>
- * same resolution. Additionally, userspace applications such as Video playback<br>
- * can read this modeset list and change the refresh rate based on the video<br>
- * frame rate. Finally, the userspace can also derive an appropriate mode for a<br>
- * particular refresh rate based on the FreeSync Mode and add it to the<br>
- * connector's mode list.<br>
- *<br>
- * Note: This is an experimental feature.<br>
- *<br>
- * The default value: 0 (off).<br>
- */<br>
-MODULE_PARM_DESC(<br>
- freesync_video,<br>
- "Enable freesync modesetting optimization feature (0 = off (default), 1 = on)");<br>
-module_param_named(freesync_video, amdgpu_freesync_vid_mode, uint, 0444);<br>
-<br>
/**<br>
* DOC: reset_method (int)<br>
* GPU reset method (-1 = auto (default), 0 = legacy, 1 = mode0, 2 = mode1, 3 = mode2, 4 = baco)<br>
-- <br>
2.41.0<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>