<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left">
[AMD Official Use Only - General]<br>
</p>
<br>
<div>
<div dir="auto">As mentioned with an older version of this series, this is an 'abuse' of power profile interface.</div>
<div dir="auto"><br>
</div>
<div dir="auto">This series is oversimplifying what PMFW algorithms are supposed to be doing. Whatever this series is doing, FW can do it better.<span></span></div>
<div dir="auto"><br>
</div>
<div dir="auto">To explain in simpler terms - it just tries to boost a profile based on ring type without even knowing how much of activity a job can trigger on a partic<span>ular ring. A job scheduled to a GFX ring doesn't deserve a profile boost unless it
can create a certain level of activity. In CPU terms, a job scheduled to a processor doesn't mean it deserves a frequency boost of that CPU. At minimum it depends on more details like whether that job is compute bound or memory bound or memory bound. </span></div>
<div dir="auto"><span><br>
</span></div>
<div dir="auto"><span>While FW algorithms are designed to do that, this series tries to trivialise all such things.</span></div>
<div dir="auto"><span><br>
</span></div>
<div dir="auto"><span>Unless you are able to show the tangible benefits in some terms like performance, power, or performance per watt, I don't think this should be the default behaviour where driver tries to override FW just based on job submissions to rings.<span></span></span></div>
<div dir="auto"></div>
<div dir="auto"><br>
</div>
<div id="ms-outlook-mobile-signature" dir="auto">Thanks,<br>
Lijo</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Arvind Yadav <Arvind.Yadav@amd.com><br>
<b>Sent:</b> Monday, August 28, 2023 5:56:07 PM<br>
<b>To:</b> Koenig, Christian <Christian.Koenig@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Sharma, Shashank <Shashank.Sharma@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; airlied@gmail.com <airlied@gmail.com>; daniel@ffwll.ch <daniel@ffwll.ch>;
Kuehling, Felix <Felix.Kuehling@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Yadav, Arvind <Arvind.Yadav@amd.com>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org><br>
<b>Subject:</b> [PATCH v3 0/7] GPU workload hints for better performance</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">AMDGPU SOCs supports dynamic workload based power profiles, which can<br>
provide fine-tuned performance for a particular type of workload.<br>
This patch series adds an interface to set/reset these power profiles<br>
based on the submitted job. The driver can dynamically switch<br>
the power profiles based on submitted job. This can optimize the power<br>
performance when the particular workload is on. <br>
<br>
v2:<br>
- Splitting workload_profile_set and workload_profile_put<br>
into two separate patches.<br>
- Addressed review comment.<br>
- Added new suspend function.<br>
- Added patch to switches the GPU workload mode for KFD. <br>
<br>
v3:<br>
- Addressed all review comment.<br>
- Changed the function name from *_set() to *_get().<br>
- Now clearing all the profile in work handler.<br>
- Added *_clear_all function to clear all the power profile.<br>
<br>
<br>
Arvind Yadav (7):<br>
drm/amdgpu: Added init/fini functions for workload<br>
drm/amdgpu: Add new function to set GPU power profile<br>
drm/amdgpu: Add new function to put GPU power profile<br>
drm/amdgpu: Add suspend function to clear the GPU power profile.<br>
drm/amdgpu: Set/Reset GPU workload profile<br>
drm/amdgpu: switch workload context to/from compute<br>
Revert "drm/amd/amdgpu: switch on/off vcn power profile mode"<br>
<br>
drivers/gpu/drm/amd/amdgpu/Makefile | 2 +-<br>
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 +<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 8 +-<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 5 +<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 14 +-<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_workload.c | 226 ++++++++++++++++++<br>
drivers/gpu/drm/amd/include/amdgpu_workload.h | 61 +++++<br>
8 files changed, 309 insertions(+), 16 deletions(-)<br>
create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_workload.c<br>
create mode 100644 drivers/gpu/drm/amd/include/amdgpu_workload.h<br>
<br>
-- <br>
2.34.1<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>