<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left">
[AMD Official Use Only - General]<br>
</p>
<br>
<div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Series is:</div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Acked-by: Alex Deucher <alexander.deucher@amd.com></div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
<br>
</div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
On a somewhat related note, we should fix the hysteresis values. They are currently set to the min and max temperatures which IIRC was not the intent of these values in hwmon.</div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
<br>
</div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Alex</div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Lazar, Lijo <Lijo.Lazar@amd.com><br>
<b>Sent:</b> Wednesday, September 20, 2023 6:40 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Zhang, Hawking <Hawking.Zhang@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com><br>
<b>Subject:</b> [PATCH 2/2] drm/amd/pm: Add GC v9.4.3 thermal limits to hwmon</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Publish max operating temperature of SOC and memory as temp*_emergency<br>
nodes in hwmon. temp*_crit will show the throttle temperature limits.<br>
<br>
Signed-off-by: Lijo Lazar <lijo.lazar@amd.com><br>
---<br>
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 19 ++++++++++++-------<br>
1 file changed, 12 insertions(+), 7 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c<br>
index 2807f3bd9ebe..5d84cdcd7c0e 100644<br>
--- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c<br>
+++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c<br>
@@ -3353,15 +3353,20 @@ static umode_t hwmon_attributes_visible(struct kobject *kobj,<br>
return 0;<br>
<br>
/* hotspot temperature for gc 9,4,3*/<br>
- if ((gc_ver == IP_VERSION(9, 4, 3)) &&<br>
- (attr == &sensor_dev_attr_temp1_input.dev_attr.attr ||<br>
- attr == &sensor_dev_attr_temp1_label.dev_attr.attr))<br>
- return 0;<br>
+ if (gc_ver == IP_VERSION(9, 4, 3)) {<br>
+ if (attr == &sensor_dev_attr_temp1_input.dev_attr.attr ||<br>
+ attr == &sensor_dev_attr_temp1_emergency.dev_attr.attr ||<br>
+ attr == &sensor_dev_attr_temp1_label.dev_attr.attr)<br>
+ return 0;<br>
+<br>
+ if (attr == &sensor_dev_attr_temp2_emergency.dev_attr.attr ||<br>
+ attr == &sensor_dev_attr_temp3_emergency.dev_attr.attr)<br>
+ return attr->mode;<br>
+ }<br>
<br>
/* only SOC15 dGPUs support hotspot and mem temperatures */<br>
- if (((adev->flags & AMD_IS_APU) || gc_ver < IP_VERSION(9, 0, 0) ||<br>
- (gc_ver == IP_VERSION(9, 4, 3))) &&<br>
- (attr == &sensor_dev_attr_temp2_crit_hyst.dev_attr.attr ||<br>
+ if (((adev->flags & AMD_IS_APU) || gc_ver < IP_VERSION(9, 0, 0)) &&<br>
+ (attr == &sensor_dev_attr_temp2_crit_hyst.dev_attr.attr ||<br>
attr == &sensor_dev_attr_temp3_crit_hyst.dev_attr.attr ||<br>
attr == &sensor_dev_attr_temp1_emergency.dev_attr.attr ||<br>
attr == &sensor_dev_attr_temp2_emergency.dev_attr.attr ||<br>
-- <br>
2.25.1<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>