<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p>Please ignore the change for "<span style="white-space: pre-wrap">static uint32_t atom_get_src_int", this doesn't fix the warning, will try to send updated version.</span></p>
<div class="moz-cite-prefix">On 12/27/2023 3:34 PM, SHANMUGAM,
SRINIVASAN wrote:<br>
</div>
<blockquote type="cite" cite="mid:20231227100417.3504719-1-srinivasan.shanmugam@amd.com">
<pre class="moz-quote-pre" wrap="">Fixes the below:
drivers/gpu/drm/amd/amdgpu/atom.c:316 atom_get_src_int() warn: ignoring unreachable code.
drivers/gpu/drm/amd/amdgpu/atom.c:398 atom_skip_src_int() warn: ignoring unreachable code.
Cc: Christian König <a class="moz-txt-link-rfc2396E" href="mailto:christian.koenig@amd.com"><christian.koenig@amd.com></a>
Cc: Alex Deucher <a class="moz-txt-link-rfc2396E" href="mailto:alexander.deucher@amd.com"><alexander.deucher@amd.com></a>
Signed-off-by: Srinivasan Shanmugam <a class="moz-txt-link-rfc2396E" href="mailto:srinivasan.shanmugam@amd.com"><srinivasan.shanmugam@amd.com></a>
---
v2:
Removed below redundant code from v1
+ val = 0;
+ break;
drivers/gpu/drm/amd/amdgpu/atom.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/atom.c b/drivers/gpu/drm/amd/amdgpu/atom.c
index 2c221000782c..10ec7d75ce7b 100644
--- a/drivers/gpu/drm/amd/amdgpu/atom.c
+++ b/drivers/gpu/drm/amd/amdgpu/atom.c
@@ -313,7 +313,6 @@ static uint32_t atom_get_src_int(atom_exec_context *ctx, uint8_t attr,
DEBUG("IMM 0x%02X\n", val);
return val;
}
- return 0;
case ATOM_ARG_PLL:
idx = U8(*ptr);
(*ptr)++;
@@ -395,7 +394,6 @@ static void atom_skip_src_int(atom_exec_context *ctx, uint8_t attr, int *ptr)
(*ptr)++;
return;
}
- return;
}
}
</pre>
</blockquote>
</body>
</html>