<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left">
[AMD Official Use Only - General]<br>
</p>
<br>
<div>
<div class="elementToProof"><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">Prefer drm_err instead of DRM_ERR:
<a href="https://elixir.bootlin.com/linux/latest/source/include/drm/drm_print.h#L468" id="LPlnk793248">
https://elixir.bootlin.com/linux/latest/source/include/drm/drm_print.h#L468</a></span></div>
<div class="elementToProof"><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"><br>
</span></div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
With or without that fixed, patch is<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com><br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="Signature">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
--</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Regards,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Jay<br>
</div>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> SHANMUGAM, SRINIVASAN <SRINIVASAN.SHANMUGAM@amd.com><br>
<b>Sent:</b> Tuesday, January 30, 2024 4:45 AM<br>
<b>To:</b> Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; Pillai, Aurabindo <Aurabindo.Pillai@amd.com><br>
<b>Cc:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; Julia Lawall <julia.lawall@inria.fr>; Hung, Alex <Alex.Hung@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Chung, ChiaHsuan (Tom) <ChiaHsuan.Chung@amd.com><br>
<b>Subject:</b> Re: [PATCH] drm/amd/display: Add NULL check for kzalloc in 'amdgpu_dm_atomic_commit_tail()'</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">+ Cc: Tom Chung <chiahsuan.chung@amd.com><br>
<br>
On 1/30/2024 2:11 PM, SHANMUGAM, SRINIVASAN wrote:<br>
> Add a NULL check for the kzalloc call that allocates memory for<br>
> dummy_updates in the amdgpu_dm_atomic_commit_tail function. Previously,<br>
> if kzalloc failed to allocate memory and returned NULL, the code would<br>
> attempt to use the NULL pointer.<br>
><br>
> The fix is to check if kzalloc returns NULL, and if so, log an error<br>
> message and skip the rest of the current loop iteration with the<br>
> continue statement. This prevents the code from attempting to use the<br>
> NULL pointer.<br>
><br>
> Cc: Julia Lawall <julia.lawall@inria.fr><br>
> Cc: Aurabindo Pillai <aurabindo.pillai@amd.com><br>
> Cc: Rodrigo Siqueira <rodrigo.siqueira@amd.com><br>
> Cc: Alex Hung <alex.hung@amd.com><br>
> Cc: Alex Deucher <alexander.deucher@amd.com><br>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com><br>
> ---<br>
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++++<br>
> 1 file changed, 4 insertions(+)<br>
><br>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c<br>
> index 0bf1bc7ced7d..8590c9f1dda6 100644<br>
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c<br>
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c<br>
> @@ -9236,6 +9236,10 @@ static void amdgpu_dm_atomic_commit_tail(struct drm_atomic_state *state)<br>
> * To fix this, DC should permit updating only stream properties.<br>
> */<br>
> dummy_updates = kzalloc(sizeof(struct dc_surface_update) * MAX_SURFACES, GFP_ATOMIC);<br>
> + if (!dummy_updates) {<br>
> + DRM_ERROR("Failed to allocate memory for dummy_updates.\n");<br>
> + continue;<br>
> + }<br>
> for (j = 0; j < status->plane_count; j++)<br>
> dummy_updates[j].surface = status->plane_states[0];<br>
> <br>
</div>
</span></font></div>
</div>
</body>
</html>