<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left">
[AMD Official Use Only - General]<br>
</p>
<br>
<div>
<div class="elementToProof"><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com></span></div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="Signature">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
--</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Regards,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Jay<br>
</div>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> SHANMUGAM, SRINIVASAN <SRINIVASAN.SHANMUGAM@amd.com><br>
<b>Sent:</b> Monday, February 12, 2024 10:33 AM<br>
<b>To:</b> Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; Pillai, Aurabindo <Aurabindo.Pillai@amd.com><br>
<b>Cc:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; SHANMUGAM, SRINIVASAN <SRINIVASAN.SHANMUGAM@amd.com>; Lakha, Bhawanpreet <Bhawanpreet.Lakha@amd.com>; Chung, ChiaHsuan (Tom) <ChiaHsuan.Chung@amd.com>; Li, Roman <Roman.Li@amd.com><br>
<b>Subject:</b> [PATCH v2] drm/amdgpu/display: Initialize gamma correction mode variable in dcn30_get_gamcor_current()</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">The dcn30_get_gamcor_current() function is responsible for determining<br>
the current gamma correction mode used by the display controller.<br>
However, the 'mode' variable, which stores the gamma correction mode,<br>
was not initialized before its first usage, leading to an uninitialized<br>
symbol error.<br>
<br>
Thus initializes the 'mode' variable with a default value of LUT_BYPASS<br>
before the conditional statements in the function, improves code clarity<br>
and stability, ensuring correct behavior of the<br>
dcn30_get_gamcor_current() function in determining the gamma correction<br>
mode.<br>
<br>
Fixes the below:<br>
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_dpp_cm.c:77 dpp30_get_gamcor_current() error: uninitialized symbol 'mode'.<br>
<br>
Fixes: 03f54d7d3448 ("drm/amd/display: Add DCN3 DPP")<br>
Cc: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com><br>
Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com><br>
Cc: Aurabindo Pillai <aurabindo.pillai@amd.com><br>
Cc: Tom Chung <chiahsuan.chung@amd.com><br>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com><br>
Suggested-by: Roman Li <roman.li@amd.com><br>
---<br>
v2:<br>
- removed the below redundant code (Roman)<br>
if (state_mode == 0)<br>
mode = LUT_BYPASS; <br>
<br>
drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c | 5 +----<br>
1 file changed, 1 insertion(+), 4 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c<br>
index 54ec144f7b81..2f5b3fbd3507 100644<br>
--- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c<br>
+++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dpp_cm.c<br>
@@ -56,16 +56,13 @@ static void dpp3_enable_cm_block(<br>
<br>
static enum dc_lut_mode dpp30_get_gamcor_current(struct dpp *dpp_base)<br>
{<br>
- enum dc_lut_mode mode;<br>
+ enum dc_lut_mode mode = LUT_BYPASS;<br>
uint32_t state_mode;<br>
uint32_t lut_mode;<br>
struct dcn3_dpp *dpp = TO_DCN30_DPP(dpp_base);<br>
<br>
REG_GET(CM_GAMCOR_CONTROL, CM_GAMCOR_MODE_CURRENT, &state_mode);<br>
<br>
- if (state_mode == 0)<br>
- mode = LUT_BYPASS;<br>
-<br>
if (state_mode == 2) {//Programmable RAM LUT<br>
REG_GET(CM_GAMCOR_CONTROL, CM_GAMCOR_SELECT_CURRENT, &lut_mode);<br>
if (lut_mode == 0)<br>
-- <br>
2.34.1<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>