<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#008000;margin:15pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left">
[Public]<br>
</p>
<br>
<div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Reviewed-by: Alex Deucher <alexander.deucher@amd.com></div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> SHANMUGAM, SRINIVASAN <SRINIVASAN.SHANMUGAM@amd.com><br>
<b>Sent:</b> Saturday, February 24, 2024 1:38 AM<br>
<b>To:</b> Koenig, Christian <Christian.Koenig@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com><br>
<b>Cc:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; SHANMUGAM, SRINIVASAN <SRINIVASAN.SHANMUGAM@amd.com>; Jammy Zhou <Jammy.Zhou@amd.com><br>
<b>Subject:</b> [PATCH] drm/amdgpu: Fix missing break in ATOM_ARG_IMM Case of atom_get_src_int()</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Missing break statement in the ATOM_ARG_IMM case of a switch statement,<br>
adds the missing break statement, ensuring that the program's control<br>
flow is as intended.<br>
<br>
Fixes the below:<br>
drivers/gpu/drm/amd/amdgpu/atom.c:323 atom_get_src_int() warn: ignoring unreachable code.<br>
<br>
Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")<br>
Cc: Jammy Zhou <Jammy.Zhou@amd.com><br>
Cc: Christian König <christian.koenig@amd.com><br>
Cc: Alex Deucher <alexander.deucher@amd.com><br>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdgpu/atom.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/atom.c b/drivers/gpu/drm/amd/amdgpu/atom.c<br>
index b888613f653f..72362df352f6 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/atom.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/atom.c<br>
@@ -320,7 +320,7 @@ static uint32_t atom_get_src_int(atom_exec_context *ctx, uint8_t attr,<br>
DEBUG("IMM 0x%02X\n", val);<br>
return val;<br>
}<br>
- return 0;<br>
+ break;<br>
case ATOM_ARG_PLL:<br>
idx = U8(*ptr);<br>
(*ptr)++;<br>
-- <br>
2.34.1<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>