<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left"> [AMD Official Use Only - General]<br> </p> <br> <div> <div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; color: rgb(0, 0, 0);"> <span style="font-size: 12pt;">These changes are for vcn_unified_ring_test_ib which only used on VCN4 and VCN5. The only except</span><span style="font-size: 11pt;">ion is ib_size_alignment of hw_ip_info.</span></div> <div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"> <br> </div> <div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"> The VCN5 adds address_patch_enabled in session_info. VCN4 doesn't have it, so it should just ignore the extra 0.</div> <div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"> <br> </div> <div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"> typedef struct uve_session_info_s</div> <div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"> {</div> <div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"> unsigned int interface_version; ///< The version of the firmware interface on which the host was built</div> <div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"> unsigned int sw_context_address_hi; ///< High address of software context buffer</div> <div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"> unsigned int sw_context_address_lo; ///< Low address of software context buffer</div> <div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"> unsigned int address_patch_enabled; ///< address patching enabled in UMD</div> <div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"> } uve_session_info_t;</div> <div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"> <br> </div> <div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"> By my tests, I didn't find error. I may need more tests on mi300 asic.</div> <div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"> <br> </div> <div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"> Thanks,</div> <div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"> Sonny</div> <div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"> <br> </div> <div id="appendonsend"></div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Alex Deucher <alexdeucher@gmail.com><br> <b>Sent:</b> Monday, April 15, 2024 5:32 PM<br> <b>To:</b> Jiang, Sonny <Sonny.Jiang@amd.com><br> <b>Cc:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; Jiang, Sonny <Sonny.Jiang@amd.com><br> <b>Subject:</b> Re: [PATCH 2/2] drm/amdgpu: IB test encode test package change for VCN5</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">On Mon, Apr 15, 2024 at 5:25 PM Sonny Jiang <sonny.jiang@amd.com> wrote:<br> ><br> > From: Sonny Jiang <sonjiang@amd.com><br> ><br> > VCN5 session info package interface changed<br> ><br> > Signed-off-by: Sonny Jiang <sonny.jiang@amd.com><br> > ---<br> > drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 4 ++--<br> > 1 file changed, 2 insertions(+), 2 deletions(-)<br> ><br> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c<br> > index 7d176046498f..e08aacacc43e 100644<br> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c<br> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c<br> > @@ -882,7 +882,7 @@ static int amdgpu_vcn_enc_get_create_msg(struct amdgpu_ring *ring, uint32_t hand<br> > ib->ptr[ib->length_dw++] = handle;<br> > ib->ptr[ib->length_dw++] = upper_32_bits(addr);<br> > ib->ptr[ib->length_dw++] = addr;<br> > - ib->ptr[ib->length_dw++] = 0x0000000b;<br> > + ib->ptr[ib->length_dw++] = 0x00000000;<br> ><br> > ib->ptr[ib->length_dw++] = 0x00000014;<br> > ib->ptr[ib->length_dw++] = 0x00000002; /* task info */<br> > @@ -949,7 +949,7 @@ static int amdgpu_vcn_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t han<br> > ib->ptr[ib->length_dw++] = handle;<br> > ib->ptr[ib->length_dw++] = upper_32_bits(addr);<br> > ib->ptr[ib->length_dw++] = addr;<br> > - ib->ptr[ib->length_dw++] = 0x0000000b;<br> > + ib->ptr[ib->length_dw++] = 0x00000000;<br> <br> These patches are touching common files, are these changes safe on pre-VCN5 IPs?<br> <br> Alex<br> <br> ><br> > ib->ptr[ib->length_dw++] = 0x00000014;<br> > ib->ptr[ib->length_dw++] = 0x00000002;<br> > --<br> > 2.43.2<br> ><br> </div> </span></font></div> </div> </body> </html>