<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 4/25/2024 7:43 PM, Lazar, Lijo
wrote:<br>
</div>
<blockquote type="cite" cite="mid:6a0f8917-3a86-4f18-8a76-1e4062e44865@amd.com">
<pre class="moz-quote-pre" wrap="">
On 4/25/2024 3:53 PM, Sunil Khatri wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Do not dump the ip registers during driver reload
in passthrough environment.
Signed-off-by: Sunil Khatri <a class="moz-txt-link-rfc2396E" href="mailto:sunil.khatri@amd.com"><sunil.khatri@amd.com></a>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 869256394136..b50758482530 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -5372,10 +5372,12 @@ int amdgpu_do_asic_reset(struct list_head *device_list_handle,
amdgpu_reset_reg_dumps(tmp_adev);
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Probably not related, can the above step be clubbed with what's being
done below? Or, can we move all such to start with amdgpu_reset_dump_*?</pre>
</blockquote>
Sure lizo<br>
<br>
<p>I will club both dump_ip_state and <span style="white-space: pre-wrap">amdgpu_reset_reg_dumps under one if condition in the patch to push.</span></p>
<p><span style="white-space: pre-wrap">Regards
Sunil
</span></p>
<blockquote type="cite" cite="mid:6a0f8917-3a86-4f18-8a76-1e4062e44865@amd.com">
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
/* Trigger ip dump before we reset the asic */
- for (i = 0; i < tmp_adev->num_ip_blocks; i++)
- if (tmp_adev->ip_blocks[i].version->funcs->dump_ip_state)
- tmp_adev->ip_blocks[i].version->funcs->dump_ip_state(
- (void *)tmp_adev);
+ if (!test_bit(AMDGPU_SKIP_COREDUMP, &reset_context->flags)) {
+ for (i = 0; i < tmp_adev->num_ip_blocks; i++)
+ if (tmp_adev->ip_blocks[i].version->funcs->dump_ip_state)
+ tmp_adev->ip_blocks[i].version->funcs
+ ->dump_ip_state((void *)tmp_adev);
+ }
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Anyway,
Reviewed-by: Lijo Lazar <a class="moz-txt-link-rfc2396E" href="mailto:lijo.lazar@amd.com"><lijo.lazar@amd.com></a>
Thanks,
Lijo
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
reset_context->reset_device_list = device_list_handle;
r = amdgpu_reset_perform_reset(tmp_adev, reset_context);
</pre>
</blockquote>
</blockquote>
</body>
</html>