<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left">
[AMD Official Use Only - General]<br>
</p>
<br>
<div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks for the review!</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
Just sent a v2</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Wentland, Harry <Harry.Wentland@amd.com><br>
<b>Sent:</b> Tuesday, April 30, 2024 9:36 AM<br>
<b>To:</b> Pillai, Aurabindo <Aurabindo.Pillai@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com><br>
<b>Subject:</b> Re: [PATCH] drm/amd/display: Override DCN410 IP version</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText"><br>
<br>
On 2024-04-30 09:23, Aurabindo Pillai wrote:<br>
> Override DCN IP version to 4.0.1 from 4.1.0 temporarily until change is<br>
> made in DC codebase to use 4.1.0<br>
> <br>
> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com><br>
> ---<br>
> drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 5 +++++<br>
> 1 file changed, 5 insertions(+)<br>
> <br>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c<br>
> index 2aad1ba0ab9d..87a2f15c8a64 100644<br>
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c<br>
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c<br>
> @@ -1965,6 +1965,11 @@ static int amdgpu_discovery_set_display_ip_blocks(struct amdgpu_device *adev)<br>
> case IP_VERSION(3, 2, 1):<br>
> case IP_VERSION(3, 5, 0):<br>
> case IP_VERSION(3, 5, 1):<br>
> + case IP_VERSION(4, 1, 0):<br>
<br>
Doesn't this do more than override? Doesn't this enable IP<br>
creation for DCN 4.1.0 in the first place?<br>
<br>
It might make sense to split this into a separate patch<br>
as it sounds like we'll want to revert the override at<br>
some point in the future but not the IP creation.<br>
<br>
Harry<br>
<br>
> + /* TODO: Fix IP version. DC code expects version 4.0.1 */<br>
> + if (adev->ip_versions[DCE_HWIP][0] == IP_VERSION(4, 1, 0))<br>
> + adev->ip_versions[DCE_HWIP][0] = IP_VERSION(4, 0, 1);<br>
> +<br>
> if (amdgpu_sriov_vf(adev))<br>
> amdgpu_discovery_set_sriov_display(adev);<br>
> else<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>