<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Calibri;font-size:10pt;color:#0000FF;margin:5pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left">
[AMD Official Use Only - AMD Internal Distribution Only]<br>
</p>
<br>
<div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Reviewed-by: Alex Deucher <alexander.deucher@amd.com></div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Jesse Zhang <jesse.zhang@amd.com><br>
<b>Sent:</b> Tuesday, May 21, 2024 3:16 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Huang, Tim <Tim.Huang@amd.com>; Zhang, Jesse(Jie) <Jesse.Zhang@amd.com>; Zhang, Jesse(Jie) <Jesse.Zhang@amd.com><br>
<b>Subject:</b> [PATCH 2/4 V2] drm/amd/pm: fix unsigned value asic_type compared against</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Enum asic_type always greater than or equal CHIP_TAHITI.<br>
<br>
Signed-off-by: Jesse Zhang <Jesse.Zhang@amd.com><br>
Suggested-by: Tim Huang <Tim.Huang@amd.com><br>
---<br>
drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 8 ++------<br>
1 file changed, 2 insertions(+), 6 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c b/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c<br>
index f245fc0bc6d3..68ac01a8bc3a 100644<br>
--- a/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c<br>
+++ b/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c<br>
@@ -7928,12 +7928,8 @@ static void si_dpm_print_power_state(void *handle,<br>
DRM_INFO("\tuvd vclk: %d dclk: %d\n", rps->vclk, rps->dclk);<br>
for (i = 0; i < ps->performance_level_count; i++) {<br>
pl = &ps->performance_levels[i];<br>
- if (adev->asic_type >= CHIP_TAHITI)<br>
- DRM_INFO("\t\tpower level %d sclk: %u mclk: %u vddc: %u vddci: %u pcie gen: %u\n",<br>
- i, pl->sclk, pl->mclk, pl->vddc, pl->vddci, pl->pcie_gen + 1);<br>
- else<br>
- DRM_INFO("\t\tpower level %d sclk: %u mclk: %u vddc: %u vddci: %u\n",<br>
- i, pl->sclk, pl->mclk, pl->vddc, pl->vddci);<br>
+ DRM_INFO("\t\tpower level %d sclk: %u mclk: %u vddc: %u vddci: %u pcie gen: %u\n",<br>
+ i, pl->sclk, pl->mclk, pl->vddc, pl->vddci, pl->pcie_gen + 1);<br>
}<br>
amdgpu_dpm_print_ps_status(adev, rps);<br>
}<br>
-- <br>
2.25.1<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>