<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Calibri;font-size:10pt;color:#0000FF;margin:5pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left">
[AMD Official Use Only - AMD Internal Distribution Only]<br>
</p>
<br>
<div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Reviewed-by: Alex Deucher <alexander.deucher@amd.com></div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Jesse Zhang <jesse.zhang@amd.com><br>
<b>Sent:</b> Tuesday, May 21, 2024 3:17 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Huang, Tim <Tim.Huang@amd.com>; Zhang, Jesse(Jie) <Jesse.Zhang@amd.com>; Zhang, Jesse(Jie) <Jesse.Zhang@amd.com><br>
<b>Subject:</b> [PATCH 3/4 V3] drm/amdgpu: fix invadate operation for pg_flags</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Since the type of pg_flags is u32, adev->pg_flags >> 16 >> 16 is 0<br>
regardless of the values of its operands.<br>
<br>
So removing the operations upper_32_bits and lower_32_bits.<br>
<br>
Signed-off-by: Jesse Zhang <Jesse.Zhang@amd.com><br>
Suggested-by: Tim Huang <Tim.Huang@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 ++--<br>
1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c<br>
index ac0ba8b8c1aa..0e1a11b6b989 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c<br>
@@ -918,7 +918,7 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,<br>
<br>
/* rev==1 */<br>
config[no_regs++] = adev->rev_id;<br>
- config[no_regs++] = lower_32_bits(adev->pg_flags);<br>
+ config[no_regs++] = adev->pg_flags;<br>
config[no_regs++] = lower_32_bits(adev->cg_flags);<br>
<br>
/* rev==2 */<br>
@@ -935,7 +935,7 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf,<br>
config[no_regs++] = adev->flags & AMD_IS_APU ? 1 : 0;<br>
<br>
/* rev==5 PG/CG flag upper 32bit */<br>
- config[no_regs++] = upper_32_bits(adev->pg_flags);<br>
+ config[no_regs++] = 0;<br>
config[no_regs++] = upper_32_bits(adev->cg_flags);<br>
<br>
while (size && (*pos < no_regs * 4)) {<br>
-- <br>
2.25.1<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>