<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> [AMD Official Use Only - AMD Internal Distribution Only] <div> <div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> The patch is Reviewed-by: Sonny Jiang <sonjiang@amd.com></div> <div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> </div> <div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Thanks,</div> <div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Sonny</div> <div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> </div> <div id="appendonsend"></div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr">From: Dong, Ruijing <Ruijing.Dong@amd.com> Sent: Thursday, May 23, 2024 12:58 PM To: Wu, David <David.Wu3@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; Koenig, Christian <Christian.Koenig@amd.com> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Liu, Leo <Leo.Liu@amd.com>; Jiang, Sonny <Sonny.Jiang@amd.com> Subject: RE: [PATCH] drm/amdgpu: drop some kernel messages in VCN code <div> </div> </div> <div class="BodyFragment"><a name="BM_BEGIN"></a> <div>[AMD Official Use Only - AMD Internal Distribution Only] Thanks for the response, and it looks good to me. Ruijing -----Original Message----- From: Wu, David <David.Wu3@amd.com> Sent: Thursday, May 23, 2024 12:55 PM To: Dong, Ruijing <Ruijing.Dong@amd.com>; Wu, David <David.Wu3@amd.com>; amd-gfx@lists.freedesktop.org; Koenig, Christian <Christian.Koenig@amd.com> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Liu, Leo <Leo.Liu@amd.com>; Jiang, Sonny <Sonny.Jiang@amd.com> Subject: Re: [PATCH] drm/amdgpu: drop some kernel messages in VCN code please see in line. On 2024-05-23 12:02, Dong, Ruijing wrote: > [AMD Official Use Only - AMD Internal Distribution Only] > > Please see my question inline below. > > Thanks, > Ruijing > > -----Original Message----- > From: Wu, David <David.Wu3@amd.com> > Sent: Thursday, May 23, 2024 11:05 AM > To: amd-gfx@lists.freedesktop.org; Koenig, Christian > <Christian.Koenig@amd.com> > Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Liu, Leo > <Leo.Liu@amd.com>; Jiang, Sonny <Sonny.Jiang@amd.com>; Dong, Ruijing > <Ruijing.Dong@amd.com> > Subject: [PATCH] drm/amdgpu: drop some kernel messages in VCN code > > We have messages when the VCN fails to initialize and there is no need to report on success. > Also PSP loading FWs is the default for production. > > Signed-off-by: David (Ming Qiang) Wu <David.Wu3@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 1 - drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_0.c | 3 --- drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c | 10 +--------- > 3 files changed, 1 insertion(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c > index b89605b400c0..5e2b7c340724 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c > @@ -1078,7 +1078,6 @@ void amdgpu_vcn_setup_ucode(struct amdgpu_device *adev) > IP_VERSION(4, 0, 3)) > break; > } > - dev_info(adev->dev, "Will use PSP to load VCN firmware\n"); > } > } > > diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_0.c > b/drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_0.c > index 64c856bfe0cb..68ef29bc70e2 100644 > --- a/drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_0.c > @@ -145,8 +145,6 @@ static int jpeg_v5_0_0_hw_init(void *handle) > if (r) > return r; > > - DRM_DEV_INFO(adev->dev, "JPEG decode initialized successfully.\n"); > - > return 0; > } > > @@ -549,7 +547,6 @@ static const struct amdgpu_ring_funcs jpeg_v5_0_0_dec_ring_vm_funcs = { static void jpeg_v5_0_0_set_dec_ring_funcs(struct amdgpu_device *adev) { > adev->jpeg.inst->ring_dec->funcs = &jpeg_v5_0_0_dec_ring_vm_funcs; > - DRM_DEV_INFO(adev->dev, "JPEG decode is enabled in VM mode\n"); > } > > static const struct amdgpu_irq_src_funcs jpeg_v5_0_0_irq_funcs = { > diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c > b/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c > index 36d4ca645c56..070b56610c7d 100644 > --- a/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c > @@ -200,16 +200,10 @@ static int vcn_v5_0_0_hw_init(void *handle) > > r = amdgpu_ring_test_helper(ring); > if (r) > - goto done; > + return r; > } > [Ruijing] Are we assuming the hw init process always be successful? No - it could fail with errors and in this case the top level will report error. Otherwise it will succeed(and no need to report successful message). David > return 0; > -done: > - if (!r) > - DRM_INFO("VCN decode and encode initialized successfully(under %s).\n", > - (adev->pg_flags & AMD_PG_SUPPORT_VCN_DPG)?"DPG Mode":"SPG Mode"); > - > - return r; > } > > /** > @@ -1122,8 +1116,6 @@ static void > vcn_v5_0_0_set_unified_ring_funcs(struct amdgpu_device *adev) > > adev->vcn.inst[i].ring_enc[0].funcs = &vcn_v5_0_0_unified_ring_vm_funcs; > adev->vcn.inst[i].ring_enc[0].me = i; > - > - DRM_INFO("VCN(%d) encode/decode are enabled in VM mode\n", i); > } > } > > -- > 2.34.1 > </div> </div> </div> </body> </html>