<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Exchange Server">  <style></style> </head> <body> <font face="Calibri" size="2"><span style="font-size:10pt;"> <div style="padding-right:5pt;padding-left:5pt;"><font color="blue">[AMD Official Use Only - AMD Internal Distribution Only]<br> </font></div> <div style="margin-top:5pt;"><font face="Times New Roman" size="3"><span style="font-size:12pt;"><br> </span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">Fixed typo in <font color="red">red</font></span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;"> </span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">-----Original Message-----<br> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Zhang, Hawking<br> Sent: Monday, September 9, 2024 20:22<br> To: Zhou1, Tao <Tao.Zhou1@amd.com>; amd-gfx@lists.freedesktop.org<br> Cc: Zhou1, Tao <Tao.Zhou1@amd.com><br> Subject: RE: [PATCH] drm/amdgpu: disable RAS bad page feature for specific APU</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;"> </span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">[AMD Official Use Only - AMD Internal Distribution Only]</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;"> </span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">[AMD Official Use Only - AMD Internal Distribution Only]</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;"> </span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">connected_to_<font color="red">cpu</font> is legacy design - I understand UMC IP version is also used so it works. Checking is_app_apu flag is good enough at this stage.</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;"> </span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">It would be better to move the code change to amdgpu_ras_fs_init.</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;"> </span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">In addition, it's more accurate to say that bad_pae_thread is not applicable to specific app platform, or something like that. Bad bad page feature is supported on the APU, but just GPU driver is not involved.</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;"> </span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">Regards,</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">Hawking</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;"> </span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">-----Original Message-----</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">From: amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">amd-gfx-bounces@lists.freedesktop.org</a>> On Behalf Of Tao Zhou</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">Sent: Monday, September 9, 2024 19:05</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">To: <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a></span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">Cc: Zhou1, Tao <<a href="mailto:Tao.Zhou1@amd.com">Tao.Zhou1@amd.com</a>></span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">Subject: [PATCH] drm/amdgpu: disable RAS bad page feature for specific APU</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;"> </span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">The feature is unsupported on specific APU.</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;"> </span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">Signed-off-by: Tao Zhou <<a href="mailto:tao.zhou1@amd.com">tao.zhou1@amd.com</a>></span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">---</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;"> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 6 ++++++</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;"> 1 file changed, 6 insertions(+)</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;"> </span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">index dbfc41ddc3c7..d46f216a33b1 100644</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">@@ -3679,6 +3679,12 @@ int amdgpu_ras_init(struct amdgpu_device *adev)</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;"> </span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;"> amdgpu_ras_init_reserved_vram_size(adev);</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;"> </span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">+ /* bad page feature is unspported on specific APU */</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">+ if ((adev->gmc.xgmi.connected_to_cpu ||</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">+ adev->gmc.is_app_apu) &&</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">+ amdgpu_ip_version(adev, UMC_HWIP, 0) == IP_VERSION(12, 0, 0))</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">+ amdgpu_bad_page_threshold = 0;</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">+</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;"> if (amdgpu_ras_fs_init(adev)) {</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;"> r = -EINVAL;</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;"> goto release_con;</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">--</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">2.34.1</span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;"> </span></font></div> </span></font> </body> </html>