<!DOCTYPE html><html><head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body> Am 10.09.24 um 19:40 schrieb Li, Yunxiang (Teddy): <blockquote type="cite" cite="mid:SA1PR12MB8599EF01801E282D63C16754ED9A2@SA1PR12MB8599.namprd12.prod.outlook.com"> <pre class="moz-quote-pre" wrap="">[Public] </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap="">Ok that looks extremely ugly. Please just add a separate function and call that from the TTM move function. </pre> </blockquote> <pre class="moz-quote-pre" wrap=""> Should I still remove the adev argument? It is never used and causes a few call sites having to find an adev unnecessarily.</pre> </blockquote> When you have time then yes, but please make that a separate patch. <blockquote type="cite" cite="mid:SA1PR12MB8599EF01801E282D63C16754ED9A2@SA1PR12MB8599.namprd12.prod.outlook.com"> <blockquote type="cite"> <pre class="moz-quote-pre" wrap="">Please either drop that or compare each memory stat variable separately. Byte by byte compares are really frowned upon. </pre> </blockquote> <pre class="moz-quote-pre" wrap=""> I think it's probably a good idea to check for zero here, otherwise there's no way for us to know if accounting have some bug in it. I'll change it to check each field separately (maybe break it out into a small helper so it's out of the way?)</pre> </blockquote> If all fields are u64 you could do something like having an union with fields and a dynamic sized array (e.g. u64 array[]), this way you can go over all the fields without naming them explicitly. And yes separate function is probably a good idea. Christian. <blockquote type="cite" cite="mid:SA1PR12MB8599EF01801E282D63C16754ED9A2@SA1PR12MB8599.namprd12.prod.outlook.com"> <pre class="moz-quote-pre" wrap=""> Teddy </pre> </blockquote> </body> </html>