<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Calibri;font-size:10pt;color:#0000FF;margin:5pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left">
[AMD Official Use Only - AMD Internal Distribution Only]<br>
</p>
<br>
<div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Acked-by: Alex Deucher <alexander.deucher@amd.com></div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Yin, ZhenGuo (Chris) <ZhenGuo.Yin@amd.com><br>
<b>Sent:</b> Thursday, September 19, 2024 1:53 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Deucher, Alexander <Alexander.Deucher@amd.com>; Chen, Jingwen <Jingwen.Chen@amd.com>; cao, lin <lin.cao@amd.com>; Yin, ZhenGuo (Chris) <ZhenGuo.Yin@amd.com><br>
<b>Subject:</b> [PATCH] drm/amdgpu: skip coredump after job timeout in SRIOV</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">VF FLR will be triggered by host driver before job timeout,<br>
hence the error status of GPU get cleared. Performing a<br>
coredump here is unnecessary.<br>
<br>
Signed-off-by: ZhenGuo Yin <zhenguo.yin@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 5 ++++-<br>
1 file changed, 4 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c<br>
index 381c886298bf..13a3604cf107 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c<br>
@@ -107,8 +107,11 @@ static enum drm_gpu_sched_stat amdgpu_job_timedout(struct drm_sched_job *s_job)<br>
/*<br>
* Do the coredump immediately after a job timeout to get a very<br>
* close dump/snapshot/representation of GPU's current error status<br>
+ * Skip it for SRIOV, since VF FLR will be triggered by host driver<br>
+ * before job timeout<br>
*/<br>
- amdgpu_job_core_dump(adev, job);<br>
+ if (!amdgpu_sriov_vf(adev))<br>
+ amdgpu_job_core_dump(adev, job);<br>
<br>
if (amdgpu_gpu_recovery &&<br>
amdgpu_ring_soft_recovery(ring, job->vmid, s_job->s_fence->parent)) {<br>
-- <br>
2.35.1<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>