<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<br>
<font face="monospace">All occurrences of this error fix should have
been together in a single patch both in _get and _set callbacks
corresponding to <span style="white-space: pre-wrap">f0b19b84d391</span>,
please avoid separate patch for each occurrence.</font><br>
<p><font face="monospace">Sorry Alex, I missed to note this
yesterday.<br>
</font></p>
<br>
<font face="monospace">Regards,</font><br>
<font face="monospace">Sathish</font>
<p><font face="monospace"><br>
</font></p>
<div class="moz-cite-prefix">On 10/4/2024 1:46 PM, Advait Dhamorikar
wrote:<br>
</div>
<blockquote type="cite" cite="mid:20241004081618.27599-1-advaitdhamorikar@gmail.com">
<pre class="moz-quote-pre" wrap="">Fix shift-count-overflow when creating mask.
The expression's value may not be what the
programmer intended, because the expression is
evaluated using a narrower integer type.
Fixes: f0b19b84d391 ("drm/amdgpu: add amdgpu_jpeg_sched_mask debugfs")
Signed-off-by: Advait Dhamorikar <a class="moz-txt-link-rfc2396E" href="mailto:advaitdhamorikar@gmail.com"><advaitdhamorikar@gmail.com></a>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c
index 95e2796919fc..7df402c45f40 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c
@@ -388,7 +388,7 @@ static int amdgpu_debugfs_jpeg_sched_mask_get(void *data, u64 *val)
for (j = 0; j < adev->jpeg.num_jpeg_rings; ++j) {
ring = &adev->jpeg.inst[i].ring_dec[j];
if (ring->sched.ready)
- mask |= 1 << ((i * adev->jpeg.num_jpeg_rings) + j);
+ mask |= (u64)1 << ((i * adev->jpeg.num_jpeg_rings) + j);
}
}
*val = mask;
</pre>
</blockquote>
</body>
</html>