<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
Am 21.10.24 um 07:56 schrieb Chong Li:<br>
<blockquote type="cite" cite="mid:20241021055644.158966-1-chongli2@amd.com">
<pre class="moz-quote-pre" wrap="">change the gpu tlb flush mode to sync mode to
solve the issue in the rocm stress test.</pre>
</blockquote>
<br>
And again complete NAK to this.<br>
<br>
I've already proven together with <span data-teams="true"><span class="ui-provider dy lx ly lz ma mb mc md me mf mg mh mi mj mk ml mm mn mo mp mq mr ms mt mu mv mw mx my mz na nb nc nd ne" dir="ltr">Andjelkovic that the problem is that the rocm stress
test is broken.<br>
<br>
The test tries to access memory before it is probably mapped and
that is provable by looking into the tracelogs.<br>
<br>
Regards,<br>
Christian. <br>
</span></span><br>
<blockquote type="cite" cite="mid:20241021055644.158966-1-chongli2@amd.com">
<pre class="moz-quote-pre" wrap="">
Signed-off-by: Chong Li <a class="moz-txt-link-rfc2396E" href="mailto:chongli2@amd.com"><chongli2@amd.com></a>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm_tlb_fence.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_tlb_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_tlb_fence.c
index 51cddfa3f1e8..4d9ff7b31618 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_tlb_fence.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_tlb_fence.c
@@ -98,7 +98,6 @@ void amdgpu_vm_tlb_fence_create(struct amdgpu_device *adev, struct amdgpu_vm *vm
f->adev = adev;
f->dependency = *fence;
f->pasid = vm->pasid;
- INIT_WORK(&f->work, amdgpu_tlb_fence_work);
spin_lock_init(&f->lock);
dma_fence_init(&f->base, &amdgpu_tlb_fence_ops, &f->lock,
@@ -106,7 +105,8 @@ void amdgpu_vm_tlb_fence_create(struct amdgpu_device *adev, struct amdgpu_vm *vm
/* TODO: We probably need a separate wq here */
dma_fence_get(&f->base);
- schedule_work(&f->work);
*fence = &f->base;
+
+ amdgpu_tlb_fence_work(&f->work);
}
</pre>
</blockquote>
<br>
</body>
</html>