<div dir="ltr"><div>Please double check the COMPUTE profile set by KFD as well.</div><div><br></div><div>Thanks,<br></div><div><br></div><div>Alex<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Oct 21, 2024 at 9:18 PM Feng, Kenneth <<a href="mailto:Kenneth.Feng@amd.com">Kenneth.Feng@amd.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="msg7546077300968544512"> <div lang="EN-US" style="overflow-wrap: break-word;"> <p style="font-family:Calibri;font-size:10pt;color:rgb(0,0,255);margin:5pt;font-style:normal;font-weight:normal;text-decoration:none" align="Left"> [AMD Official Use Only - AMD Internal Distribution Only]<br> </p> <br> <div> <div class="m_7546077300968544512WordSection1"> <p class="MsoNormal"><span style="font-size:11pt;font-family:"Arial",sans-serif">Hi Alex,<u></u><u></u></span></p> <p class="MsoNormal"><span style="font-size:11pt;font-family:"Arial",sans-serif">I have found another problem with the current code based on the default workload setting to 3D fullscreen.<u></u><u></u></span></p> <p class="MsoNormal"><span style="font-size:11pt;font-family:"Arial",sans-serif">For example, the default workload is set to 3D fullscreen first, but in boot, it’s not applied yet.<u></u><u></u></span></p> <p class="MsoNormal"><span style="font-size:11pt;font-family:"Arial",sans-serif">Then a vcn ring test comes in, sets the workload mask to vcn workload + 3D fullscreen. After the setting,<u></u><u></u></span></p> <p class="MsoNormal"><span style="font-size:11pt;font-family:"Arial",sans-serif">Actually the workload mask is updated to vcn workload only. Then after the vcn ring test, the workload doesn’t go<u></u><u></u></span></p> <p class="MsoNormal"><span style="font-size:11pt;font-family:"Arial",sans-serif">to 3D fullscreen workload. It goes to bootup workload(PP_SMC_POWER_PROFILE_BOOTUP_DEFAULT).<u></u><u></u></span></p> <p class="MsoNormal"><span style="font-size:11pt;font-family:"Arial",sans-serif">Let me try to fix it by today and get back to you.<u></u><u></u></span></p> <p class="MsoNormal"><span style="font-size:11pt;font-family:"Arial",sans-serif">For this patch itself, it’s ok.<u></u><u></u></span></p> <p class="MsoNormal"><span style="font-size:11pt;font-family:"Arial",sans-serif">Reviewed-by: Kenneth Feng <a href="mailto:kenneth.feng@amd.com" target="_blank">kenneth.feng@amd.com</a><u></u><u></u></span></p> <p class="MsoNormal"><span style="font-size:11pt;font-family:"Arial",sans-serif"><u></u> <u></u></span></p> <p class="MsoNormal"><span style="font-size:11pt;font-family:"Arial",sans-serif"><u></u> <u></u></span></p> <p class="MsoNormal"><span style="font-size:11pt;font-family:"Arial",sans-serif"><u></u> <u></u></span></p> <div> <div style="border-width:1pt medium medium;border-style:solid none none;border-color:rgb(225,225,225) currentcolor currentcolor;padding:3pt 0in 0in"> <p class="MsoNormal"><b><span style="font-size:11pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11pt;font-family:"Calibri",sans-serif"> amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org" target="_blank">amd-gfx-bounces@lists.freedesktop.org</a>> <b>On Behalf Of </b>Deucher, Alexander<br> <b>Sent:</b> Tuesday, October 22, 2024 4:35 AM<br> <b>To:</b> <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a><br> <b>Subject:</b> Re: [PATCH] drm/amdgpu: handle default profile on GC 9.4.1<u></u><u></u></span></p> </div> </div> <p class="MsoNormal"><u></u> <u></u></p> <p style="margin:5pt"><span style="font-size:10pt;font-family:"Calibri",sans-serif;color:blue">[AMD Official Use Only - AMD Internal Distribution Only]<u></u><u></u></span></p> <p class="MsoNormal"><u></u> <u></u></p> <div> <table border="0" cellspacing="0" cellpadding="0" align="left" width="100%" style="width:100%"> <tbody> <tr> <td style="background:rgb(255,185,0);padding:5pt 2pt"></td> <td width="100%" style="width:100%;background:rgb(255,248,229);padding:5pt 4pt 5pt 12pt"> <div> <p class="MsoNormal"> <b><span style="color:rgb(34,34,34)">Caution:</span></b><span style="color:rgb(34,34,34)"> This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. <u></u><u></u></span></p> </div> </td> </tr> </tbody> </table> <p class="MsoNormal"><u></u> <u></u></p> <div> <p style="margin:5pt"><span style="font-size:10pt;font-family:"Calibri",sans-serif;color:blue">[AMD Official Use Only - AMD Internal Distribution Only]<u></u><u></u></span></p> <p class="MsoNormal"><u></u> <u></u></p> <div> <div> <p class="MsoNormal"><span style="color:black">Ping?<u></u><u></u></span></p> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="m_7546077300968544512divRplyFwdMsg"> <p class="MsoNormal"><b><span style="font-size:11pt;font-family:"Calibri",sans-serif;color:black">From:</span></b><span style="font-size:11pt;font-family:"Calibri",sans-serif;color:black"> Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com" target="_blank">Alexander.Deucher@amd.com</a>><br> <b>Sent:</b> Friday, October 18, 2024 3:20 PM<br> <b>To:</b> <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a> <<a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a>><br> <b>Cc:</b> Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com" target="_blank">Alexander.Deucher@amd.com</a>><br> <b>Subject:</b> [PATCH] drm/amdgpu: handle default profile on GC 9.4.1</span> <u></u> <u></u></p> <div> <p class="MsoNormal"> <u></u><u></u></p> </div> </div> <div> <div> <p class="MsoNormal" style="margin-bottom:12pt"><span style="font-size:11pt">It does not support fullscreen 3D.<br> <br> Fixes: 336568de918e ("drm/amdgpu/swsmu: default to fullscreen 3D profile for dGPUs")<br> Signed-off-by: Alex Deucher <<a href="mailto:alexander.deucher@amd.com" target="_blank">alexander.deucher@amd.com</a>><br> ---<br> drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 3 ++-<br> 1 file changed, 2 insertions(+), 1 deletion(-)<br> <br> diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c<br> index accc96a03bd9..4b816c7e94fe 100644<br> --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c<br> +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c<br> @@ -1267,7 +1267,8 @@ static int smu_sw_init(struct amdgpu_ip_block *ip_block)<br> smu->workload_prority[PP_SMC_POWER_PROFILE_COMPUTE] = 5;<br> smu->workload_prority[PP_SMC_POWER_PROFILE_CUSTOM] = 6;<br> <br> - if (smu->is_apu)<br> + if (smu->is_apu ||<br> + (amdgpu_ip_version(adev, GC_HWIP, 0) == IP_VERSION(9, 4, 1)))<br> smu->workload_mask = 1 << smu->workload_prority[PP_SMC_POWER_PROFILE_BOOTUP_DEFAULT];<br> else<br> smu->workload_mask = 1 << smu->workload_prority[PP_SMC_POWER_PROFILE_FULLSCREEN3D];<br> -- <br> 2.46.2<u></u><u></u></span></p> </div> </div> </div> </div> </div> </div> </div> </div> </div></blockquote></div></div>