<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Exchange Server">  <style></style> </head> <body> <font face="Calibri" size="2"><span style="font-size:10pt;"> <div style="padding-right:5pt;padding-left:5pt;"><font color="blue">[AMD Official Use Only - AMD Internal Distribution Only]<br> </font></div> <div style="margin-top:5pt;"><font face="Times New Roman" size="3"><span style="font-size:12pt;"><br> </span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com></span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;"> </span></font></div> <div><font face="Calibri" size="2"><span style="font-size:11pt;">Regards,<br> Hawking</span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;">-----Original Message-----<br> From: Lazar, Lijo <Lijo.Lazar@amd.com> <br> Sent: Monday, November 4, 2024 13:11<br> To: amd-gfx@lists.freedesktop.org<br> Cc: Zhang, Hawking <Hawking.Zhang@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Kamal, Asad <Asad.Kamal@amd.com><br> Subject: [PATCH] drm/amdgpu: Fix DPX valid mode check on GC 9.4.3</span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;"> </span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;">For DPX mode, the number of memory partitions supported should be less than or equal to 2.</span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;"> </span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;">Signed-off-by: Lijo Lazar <<a href="mailto:lijo.lazar@amd.com">lijo.lazar@amd.com</a>></span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;">Fixes: 1589c82a1085 ("drm/amdgpu: Check memory ranges for valid xcp mode")</span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;">---</span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;"> drivers/gpu/drm/amd/amdgpu/aqua_vanjaram.c | 2 +-</span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;"> 1 file changed, 1 insertion(+), 1 deletion(-)</span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;"> </span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;">diff --git a/drivers/gpu/drm/amd/amdgpu/aqua_vanjaram.c b/drivers/gpu/drm/amd/amdgpu/aqua_vanjaram.c</span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;">index fccccea0d2d0..e157d6d857b6 100644</span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;">--- a/drivers/gpu/drm/amd/amdgpu/aqua_vanjaram.c</span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;">+++ b/drivers/gpu/drm/amd/amdgpu/aqua_vanjaram.c</span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;">@@ -548,7 +548,7 @@ static bool __aqua_vanjaram_is_valid_mode(struct amdgpu_xcp_mgr *xcp_mgr,</span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;"> case AMDGPU_SPX_PARTITION_MODE:</span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;"> return adev->gmc.num_mem_partitions == 1 && num_xcc > 0;</span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;"> case AMDGPU_DPX_PARTITION_MODE:</span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;">- return adev->gmc.num_mem_partitions != 8 && (num_xcc % 4) == 0;</span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;">+ return adev->gmc.num_mem_partitions <= 2 && (num_xcc % 4) == 0;</span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;"> case AMDGPU_TPX_PARTITION_MODE:</span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;"> return (adev->gmc.num_mem_partitions == 1 ||</span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;"> adev->gmc.num_mem_partitions == 3) &&</span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;">--</span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;">2.25.1</span></font></div> <div><font face="Arial" size="2"><span style="font-size:11pt;"> </span></font></div> </span></font> </body> </html>