<!DOCTYPE html><html><head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body> Hi guys, can you please explain to me why it's always you guys which come up with such nonsense? When you need to find the number of ongoing hardware submission then please use the amdgpu_fence_count_emitted() function and not mess with any scheduler internals. This patch here is a clear NAK from my side. Regards, Christian. <div class="moz-cite-prefix">Am 13.11.24 um 09:46 schrieb Fan, Shikang: </div> <blockquote type="cite" cite="mid:SA1PR12MB7343D24CCFC921D157E2CDCCEB5A2@SA1PR12MB7343.namprd12.prod.outlook.com"> <style type="text/css" style="display:none;">P {margin-top:0;margin-bottom:0;}</style> [AMD Official Use Only - AMD Internal Distribution Only] <div> <div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"> +<a href="mailto:Christian.Koenig@amd.com" id="OWAAM717321" class="tWKOu mention ms-bgc-nlr ms-fcl-b" moz-do-not-send="true">@Koenig, Christian</a> Hi Christian, Could you please help review this patch? Thank you. Regards,</div> <div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"> Shikang</div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr">From: Shikang Fan <a class="moz-txt-link-rfc2396E" href="mailto:shikang.fan@amd.com"><shikang.fan@amd.com></a> Sent: Wednesday, November 13, 2024 11:14 AM To: <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <a class="moz-txt-link-rfc2396E" href="mailto:amd-gfx@lists.freedesktop.org"><amd-gfx@lists.freedesktop.org></a> Cc: Fan, Shikang <a class="moz-txt-link-rfc2396E" href="mailto:Shikang.Fan@amd.com"><Shikang.Fan@amd.com></a>; Liu01, Tong (Esther) <a class="moz-txt-link-rfc2396E" href="mailto:Tong.Liu01@amd.com"><Tong.Liu01@amd.com></a>; Deng, Emily <a class="moz-txt-link-rfc2396E" href="mailto:Emily.Deng@amd.com"><Emily.Deng@amd.com></a> Subject: [PATCH] drm/amdgpu: Check pending job finished or not to identify has bad job <div> </div> </div> <div class="BodyFragment"> <div class="PlainText">drm_sched_free_job_work is a queue work function, so even job is finished in hw, it still needs some time to be deleted from the pending queue by drm_sched_free_job_work. here iterates over the pending job list and wait for each job to finish within specified timeout (1s by default) to avoid jobs that are not cleaned up in time or are about to finished. if wait timeout, return true Signed-off-by: Tong Liu01 <a class="moz-txt-link-rfc2396E" href="mailto:Tong.Liu01@amd.com"><Tong.Liu01@amd.com></a> Signed-off-by: Emily Deng <a class="moz-txt-link-rfc2396E" href="mailto:Emily.Deng@amd.com"><Emily.Deng@amd.com></a> Signed-off-by: Shikang Fan <a class="moz-txt-link-rfc2396E" href="mailto:shikang.fan@amd.com"><shikang.fan@amd.com></a> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 071d3d9b345d..da2a22618f42 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -100,6 +100,7 @@ MODULE_FIRMWARE("amdgpu/navi12_gpu_info.bin"); #define AMDGPU_PCIE_INDEX_FALLBACK (0x38 >> 2) #define AMDGPU_PCIE_INDEX_HI_FALLBACK (0x44 >> 2) #define AMDGPU_PCIE_DATA_FALLBACK (0x3C >> 2) +#define AMDGPU_PENDING_JOB_TIMEOUT msecs_to_jiffies(1000) static const struct drm_driver amdgpu_kms_driver; @@ -5224,7 +5225,8 @@ static int amdgpu_device_reset_sriov(struct amdgpu_device *adev, bool amdgpu_device_has_job_running(struct amdgpu_device *adev) { int i; - struct drm_sched_job *job; + struct drm_sched_job *job, *tmp; + long r; for (i = 0; i < AMDGPU_MAX_RINGS; ++i) { struct amdgpu_ring *ring = adev->rings[i]; @@ -5233,11 +5235,20 @@ bool amdgpu_device_has_job_running(struct amdgpu_device *adev) continue; spin_lock(&ring->sched.job_list_lock); - job = list_first_entry_or_null(&ring->sched.pending_list, - struct drm_sched_job, list); + + /* iterates over the pending job list + * wait for each job to finish within timeout (1s by default) + * if wait timeout, return true + */ + list_for_each_entry_safe(job, tmp, &ring->sched.pending_list, list) { + r = dma_fence_wait_timeout(&job->s_fence->finished, + false, AMDGPU_PENDING_JOB_TIMEOUT); + if (r <= 0) { + spin_unlock(&ring->sched.job_list_lock); + return true; + } + } spin_unlock(&ring->sched.job_list_lock); - if (job) - return true; } return false; } -- 2.34.1 </div> </div> </div> </blockquote> </body> </html>