<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p>
</p>
<pre style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">My<span style=" color:#c0c0c0;"> </span>Q<span style=" color:#c0c0c0;"> </span>or<span style=" color:#c0c0c0;"> </span>A<span style=" color:#c0c0c0;"> </span>is<span style=" color:#c0c0c0;"> </span><span style=" color:#ff9d04;">inline</span>.</pre>
<pre style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">
</pre>
<pre style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">Thanks!</pre>
<pre style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">James<span style=" color:#c0c0c0;"> </span>Zhu</pre>
<p><style type="text/css">p, li { white-space: pre-wrap; }</style></p>
<div class="moz-cite-prefix">On 2025-01-08 04:18, Christian König
wrote:<br>
</div>
<blockquote type="cite" cite="mid:e05a67b1-7b2f-460c-bd53-246ea1f55d5c@amd.com">Am
07.01.25 um 21:01 schrieb James Zhu:
<br>
<blockquote type="cite">this original test condition is unclear.
<br>
</blockquote>
<br>
No that is completely unnecessary.
<br>
<br>
The point is that with fence->ops->signaled provided the
fence should make progress even without enabling signaling.
<br>
<br>
Why would you want to add this?
<br>
</blockquote>
<p>[JZ]Nothing happened. just for clarification. So the code can be interpreted , if this fence has no signal op defined, we need try to use enable_signaling</p>
<p>to flush this fence. implicitly, if signal op is defined, then this fence is flushed early or later around. </p>
<blockquote type="cite" cite="mid:e05a67b1-7b2f-460c-bd53-246ea1f55d5c@amd.com">
<br>
Regards,
<br>
Christian.
<br>
<br>
<blockquote type="cite">
<br>
Signed-off-by: James Zhu <a class="moz-txt-link-rfc2396E" href="mailto:James.Zhu@amd.com"><James.Zhu@amd.com></a>
<br>
---
<br>
drivers/gpu/drm/ttm/ttm_bo.c | 2 +-
<br>
1 file changed, 1 insertion(+), 1 deletion(-)
<br>
<br>
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c
b/drivers/gpu/drm/ttm/ttm_bo.c
<br>
index 48c5365efca1..d40f07802c4f 100644
<br>
--- a/drivers/gpu/drm/ttm/ttm_bo.c
<br>
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
<br>
@@ -218,7 +218,7 @@ static void ttm_bo_flush_all_fences(struct
ttm_buffer_object *bo)
<br>
dma_resv_iter_begin(&cursor, resv,
DMA_RESV_USAGE_BOOKKEEP);
<br>
dma_resv_for_each_fence_unlocked(&cursor, fence) {
<br>
- if (!fence->ops->signaled)
<br>
+ if (fence->ops->signaled &&
!fence->ops->signaled(fence))
<br>
dma_fence_enable_sw_signaling(fence);
<br>
}
<br>
dma_resv_iter_end(&cursor);
<br>
</blockquote>
<br>
</blockquote>
</body>
</html>