<div dir="ltr"><div>So it's implemented but not enabled by default, right? </div><div> </div><div>Marek </div></div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Jan 24, 2025 at 12:40 PM Alex Deucher <<a href="mailto:alexdeucher@gmail.com" target="_blank">alexdeucher@gmail.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri, Jan 24, 2025 at 12:38 PM SRINIVASAN SHANMUGAM <<a href="mailto:srinivasan.shanmugam@amd.com" target="_blank">srinivasan.shanmugam@amd.com</a>> wrote: > > > On 1/24/2025 10:01 PM, Marek Olšák wrote: > > Does this commit really enable it though? Or is it just for sysfs? > > Yes it enables cleaner shader support not only sysfs. It enables the functionality in the kernel. It can be turned on or manually run via sysfs. Alex > > Best regards, > Srini > > Marek > > On Fri, Jan 24, 2025 at 1:42 AM Srinivasan Shanmugam <<a href="mailto:srinivasan.shanmugam@amd.com" target="_blank">srinivasan.shanmugam@amd.com</a>> wrote: >> >> Enable the cleaner shader for GFX10.1.1/10.1.2 GPUs to provide data >> isolation between GPU workloads. The cleaner shader is responsible for >> clearing the Local Data Store (LDS), Vector General Purpose Registers >> (VGPRs), and Scalar General Purpose Registers (SGPRs), which helps >> prevent data leakage and ensures accurate computation results. >> >> This update extends cleaner shader support to GFX10.1.1/10.1.2 GPUs, >> previously available for GFX10.1.10. It enhances security by clearing >> GPU memory between processes and maintains a consistent GPU state across >> KGD and KFD workloads. >> >> Cc: Christian König <<a href="mailto:christian.koenig@amd.com" target="_blank">christian.koenig@amd.com</a>> >> Cc: Alex Deucher <<a href="mailto:alexander.deucher@amd.com" target="_blank">alexander.deucher@amd.com</a>> >> Signed-off-by: Srinivasan Shanmugam <<a href="mailto:srinivasan.shanmugam@amd.com" target="_blank">srinivasan.shanmugam@amd.com</a>> >> --- >> drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c >> index 1878c83ff7e3..938f7d60a0ee 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c >> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c >> @@ -4795,6 +4795,8 @@ static int gfx_v10_0_sw_init(struct amdgpu_ip_block *ip_block) >> } >> switch (amdgpu_ip_version(adev, GC_HWIP, 0)) { >> case IP_VERSION(10, 1, 10): >> + case IP_VERSION(10, 1, 1): >> + case IP_VERSION(10, 1, 2): >> adev->gfx.cleaner_shader_ptr = gfx_10_1_10_cleaner_shader_hex; >> adev->gfx.cleaner_shader_size = sizeof(gfx_10_1_10_cleaner_shader_hex); >> if (adev->gfx.me_fw_version >= 101 && >> -- >> 2.34.1 >> </blockquote></div>