<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word"> <p style="font-family:Calibri;font-size:10pt;color:#0000FF;margin:5pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left"> [AMD Official Use Only - AMD Internal Distribution Only]<br> </p> <br> <div> <div class="WordSection1"> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Arial",sans-serif">It may be better to use the following alignment attribute rather than manually adding the padding.<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Arial",sans-serif"> <o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Arial",sans-serif">__attribute__((packed, aligned()))<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Arial",sans-serif"> <o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Arial",sans-serif">Anyway, the patch set is<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Arial",sans-serif"><o:p> </o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Arial",sans-serif">Reviewed-by: Prike Liang <<a href="mailto:Prike.Liang@amd.com">Prike.Liang@amd.com</a>><o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Arial",sans-serif"><o:p> </o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt">Regards,<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt"> Prike<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Arial",sans-serif"><o:p> </o:p></span></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Marek Olšák <maraeo@gmail.com> <br> <b>Sent:</b> Monday, April 7, 2025 1:40 PM<br> <b>To:</b> Deucher, Alexander <Alexander.Deucher@amd.com><br> <b>Cc:</b> amd-gfx@lists.freedesktop.org; Olsak, Marek <Marek.Olsak@amd.com>; Liang, Prike <Prike.Liang@amd.com>; Khatri, Sunil <Sunil.Khatri@amd.com>; Mohan Marimuthu, Yogesh <Yogesh.Mohanmarimuthu@amd.com><br> <b>Subject:</b> Re: [PATCH 1/2] drm/amdgpu: add UAPI to query if user queues are supported<o:p></o:p></span></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <div> <p class="MsoNormal">Reviewed-by: Marek Olšák <<a href="mailto:marek.olsak@amd.com" target="_blank">marek.olsak@amd.com</a>><o:p></o:p></p> </div> <div> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <p class="MsoNormal">For both patches.<o:p></o:p></p> </div> <div> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <p class="MsoNormal">Marek<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <div> <p class="MsoNormal">On Mon, Mar 24, 2025 at 4:34<span style="font-family:"Arial",sans-serif"> </span>PM Alex Deucher <<a href="mailto:alexander.deucher@amd.com" target="_blank">alexander.deucher@amd.com</a>> wrote:<o:p></o:p></p> </div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in"> <p class="MsoNormal" style="margin-bottom:12.0pt">Add an INFO query to check if user queues are supported.<br> <br> v2: switch to a mask of IPs (Marek)<br> v3: move to drm_amdgpu_info_device (Marek)<br> <br> Cc: <a href="mailto:marek.olsak@amd.com" target="_blank">marek.olsak@amd.com</a><br> Cc: <a href="mailto:prike.liang@amd.com" target="_blank">prike.liang@amd.com</a><br> Cc: <a href="mailto:sunil.khatri@amd.com" target="_blank">sunil.khatri@amd.com</a><br> Cc: <a href="mailto:yogesh.mohanmarimuthu@amd.com" target="_blank">yogesh.mohanmarimuthu@amd.com</a><br> Signed-off-by: Alex Deucher <<a href="mailto:alexander.deucher@amd.com" target="_blank">alexander.deucher@amd.com</a>><br> ---<br> drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 7 +++++++<br> include/uapi/drm/amdgpu_drm.h | 3 +++<br> 2 files changed, 10 insertions(+)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c<br> index 3b7dfd56ccd0e..0ba3ef1e4a068 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c<br> @@ -1009,6 +1009,13 @@ int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file *filp)<br> }<br> }<br> <br> + if (adev->userq_funcs[AMDGPU_HW_IP_GFX])<br> + dev_info->userq_ip_mask |= (1 << AMDGPU_HW_IP_GFX);<br> + if (adev->userq_funcs[AMDGPU_HW_IP_COMPUTE])<br> + dev_info->userq_ip_mask |= (1 << AMDGPU_HW_IP_COMPUTE);<br> + if (adev->userq_funcs[AMDGPU_HW_IP_DMA])<br> + dev_info->userq_ip_mask |= (1 << AMDGPU_HW_IP_DMA);<br> +<br> ret = copy_to_user(out, dev_info,<br> min((size_t)size, sizeof(*dev_info))) ? -EFAULT : 0;<br> kfree(dev_info);<br> diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h<br> index 5dbd9037afe75..ef97c0d78b8a0 100644<br> --- a/include/uapi/drm/amdgpu_drm.h<br> +++ b/include/uapi/drm/amdgpu_drm.h<br> @@ -1453,6 +1453,9 @@ struct drm_amdgpu_info_device {<br> __u32 csa_size;<br> /* context save area base virtual alignment for gfx11 */<br> __u32 csa_alignment;<br> + /* Userq IP mask (1 << AMDGPU_HW_IP_*) */<br> + __u32 userq_ip_mask;<br> + __u32 pad;<br> };<br> <br> struct drm_amdgpu_info_hw_ip {<br> -- <br> 2.49.0<o:p></o:p></p> </blockquote> </div> </div> </div> </div> </body> </html>