<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Calibri;font-size:10pt;color:#0000FF;margin:5pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left">
[AMD Official Use Only - AMD Internal Distribution Only]<br>
</p>
<br>
<div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Acked-by: Alex Deucher <alexander.deucher@amd.com></div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Yadav, Arvind <Arvind.Yadav@amd.com><br>
<b>Sent:</b> Friday, April 11, 2025 12:54 AM<br>
<b>To:</b> Yadav, Arvind <Arvind.Yadav@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Khatri, Sunil <Sunil.Khatri@amd.com>; Sharma, Shashank <Shashank.Sharma@amd.com><br>
<b>Cc:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Subject:</b> Re: [PATCH 2/2 v2] drm/amdgpu: Add fw minimum version check for usermode queue</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Alex,<br>
This is v2 of 2/2 patch. Please review this.<br>
<br>
~arvind<br>
<br>
On 4/10/2025 8:27 PM, Arvind Yadav wrote:<br>
> This patch is load usermode queue based on FW support for gfx12.<br>
> CP Ucode FW Vesion: [PFP = 2840, ME = 2780, MEC = 3050, MES = 123]<br>
><br>
> v2: Addressed review comments from Alex<br>
> - Just check the firmware versions directly.<br>
><br>
> Cc: Alex Deucher <alexander.deucher@amd.com><br>
> Cc: Christian Koenig <christian.koenig@amd.com><br>
> Cc: Shashank Sharma <shashank.sharma@amd.com><br>
> Cc: Sunil Khatri <sunil.khatri@amd.com><br>
> Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com><br>
> ---<br>
> drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 5 ++++-<br>
> 1 file changed, 4 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c<br>
> index 3d87e445270e..3165fdfeca6a 100644<br>
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c<br>
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c<br>
> @@ -1418,7 +1418,10 @@ static int gfx_v12_0_sw_init(struct amdgpu_ip_block *ip_block)<br>
> case IP_VERSION(12, 0, 1):<br>
> #ifdef CONFIG_DRM_AMDGPU_NAVI3X_USERQ<br>
> /* add firmware version checks here */<br>
> - if (0) {<br>
> + if (adev->gfx.me_fw_version >= 2780 &&<br>
> + adev->gfx.pfp_fw_version >= 2840 &&<br>
> + adev->gfx.mec_fw_version >= 3050 &&<br>
> + adev->mes.fw_version[0] >= 123) {<br>
> adev->userq_funcs[AMDGPU_HW_IP_GFX] = &userq_mes_funcs;<br>
> adev->userq_funcs[AMDGPU_HW_IP_COMPUTE] = &userq_mes_funcs;<br>
> }<br>
</div>
</span></font></div>
</div>
</body>
</html>