<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Calibri;font-size:10pt;color:#0000FF;margin:5pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left">
[AMD Official Use Only - AMD Internal Distribution Only]<br>
</p>
<br>
<div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Reviewed-by: <span style="font-size: 12pt;">Ce Sun <cesun102@amd.com></span></div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Khatri, Sunil <sukhatri@amd.com><br>
<b>Sent:</b> Saturday, April 12, 2025 12:33 AM<br>
<b>To:</b> Deucher, Alexander <Alexander.Deucher@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Subject:</b> Re: [PATCH] drm/amdgpu: fix no_user_submission check for SDMA</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Reviewed-by: Sunil Khatri <sunil.khatri@amd.com><br>
<br>
On 4/11/2025 6:20 PM, Alex Deucher wrote:<br>
> Copy paste typo. Use the flag from the sdma structure.<br>
><br>
> Fixes: 4310acd4464b ("drm/amdgpu: add ring flag for no user submissions")<br>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com><br>
> ---<br>
> drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +-<br>
> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
><br>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c<br>
> index 0ba3ef1e4a068..6a42dea775b10 100644<br>
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c<br>
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c<br>
> @@ -427,7 +427,7 @@ static int amdgpu_hw_ip_info(struct amdgpu_device *adev,<br>
> type = AMD_IP_BLOCK_TYPE_SDMA;<br>
> for (i = 0; i < adev->sdma.num_instances; i++)<br>
> if (adev->sdma.instance[i].ring.sched.ready &&<br>
> - !adev->gfx.gfx_ring[i].no_user_submission)<br>
> + !adev->sdma.instance[i].ring.no_user_submission)<br>
> ++num_rings;<br>
> ib_start_alignment = 256;<br>
> ib_size_alignment = 4;<br>
</div>
</span></font></div>
</div>
</body>
</html>