<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="#467886" vlink="#96607D" style="word-wrap:break-word"> [AMD Official Use Only - AMD Internal Distribution Only] <div> <div class="WordSection1"> Ye , that’s guide line , I believe that’s align with our legacy kiq usage . <o:p></o:p> <o:p> </o:p> Shaoyun.liu<o:p></o:p> <o:p> </o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: Chen, Michael <Michael.Chen@amd.com> Sent: Tuesday, April 29, 2025 3:20 PM To: Alex Deucher <alexdeucher@gmail.com>; Liu, Shaoyun <Shaoyun.Liu@amd.com> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; amd-gfx@lists.freedesktop.org; Khatri, Sunil <Sunil.Khatri@amd.com>; Liang, Prike <Prike.Liang@amd.com> Subject: Re: [PATCH 5/8] drm/amdgpu/mes12: add support for setting gang submit<o:p></o:p> </div> </div> <o:p> </o:p> [AMD Official Use Only - AMD Internal Distribution Only]<o:p></o:p> <o:p> </o:p> <div> <div> All legacy / kernel queues related ops (add / remove / reset) can go through KIQ pipe. Non queue related ops (read_reg / write_reg etc.) can go through KIQ pipe too.<o:p></o:p> </div> <div> All user queues related ops should go through SCHED pipe<o:p></o:p> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="1" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> From: Alex Deucher <<a href="mailto:alexdeucher@gmail.com">alexdeucher@gmail.com</a>> Sent: Tuesday, April 29, 2025 3:05 PM To: Liu, Shaoyun <<a href="mailto:Shaoyun.Liu@amd.com">Shaoyun.Liu@amd.com</a>> Cc: Chen, Michael <<a href="mailto:Michael.Chen@amd.com">Michael.Chen@amd.com</a>>; Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com">Alexander.Deucher@amd.com</a>>; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>>; Khatri, Sunil <<a href="mailto:Sunil.Khatri@amd.com">Sunil.Khatri@amd.com</a>>; Liang, Prike <<a href="mailto:Prike.Liang@amd.com">Prike.Liang@amd.com</a>> Subject: Re: [PATCH 5/8] drm/amdgpu/mes12: add support for setting gang submit <o:p></o:p> <div> <o:p></o:p> </div> </div> <div> <div> On Tue, Apr 29, 2025 at 2:56 PM Liu, Shaoyun <<a href="mailto:Shaoyun.Liu@amd.com">Shaoyun.Liu@amd.com</a>> wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > Correctly , the gang submission related stuff only used for scheduler pipe , kiq is for used for kernel driver only and should not expose to the user queue. What about kernel queues mapped through MES? Do those need to go through KIQ or is SCHED ok? They seem to go through KIQ today. Is going through SCHED ok? Alex > > Regards > Shaoyun.liu > > -----Original Message----- > From: amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">amd-gfx-bounces@lists.freedesktop.org</a>> On Behalf Of Alex Deucher > Sent: Tuesday, April 29, 2025 2:39 PM > To: Chen, Michael <<a href="mailto:Michael.Chen@amd.com">Michael.Chen@amd.com</a>> > Cc: Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com">Alexander.Deucher@amd.com</a>>; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>; Khatri, Sunil <<a href="mailto:Sunil.Khatri@amd.com">Sunil.Khatri@amd.com</a>>; Liang, Prike <<a href="mailto:Prike.Liang@amd.com">Prike.Liang@amd.com</a>> > Subject: Re: [PATCH 5/8] drm/amdgpu/mes12: add support for setting gang submit > > On Tue, Apr 29, 2025 at 2:23 PM Chen, Michael <<a href="mailto:Michael.Chen@amd.com">Michael.Chen@amd.com</a>> wrote: > > > > [Public] > > > > > > > > > > ________________________________ > > From: amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">amd-gfx-bounces@lists.freedesktop.org</a>> on behalf of > > Alex Deucher <<a href="mailto:alexander.deucher@amd.com">alexander.deucher@amd.com</a>> > > Sent: Monday, April 28, 2025 5:20 PM > > To: <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>> > > Cc: Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com">Alexander.Deucher@amd.com</a>>; Khatri, Sunil > > <<a href="mailto:Sunil.Khatri@amd.com">Sunil.Khatri@amd.com</a>>; Liang, Prike <<a href="mailto:Prike.Liang@amd.com">Prike.Liang@amd.com</a>> > > Subject: [PATCH 5/8] drm/amdgpu/mes12: add support for setting gang > > submit > > > > Enable a primary and secondary queue that schedule together. > > > > v2: fix offset of api_status (Prike) > > > > Acked-by: Sunil Khatri <<a href="mailto:sunil.khatri@amd.com">sunil.khatri@amd.com</a>> > > Reviewed-by: Prike Liang <<a href="mailto:Prike.Liang@amd.com">Prike.Liang@amd.com</a>> > > Signed-off-by: Alex Deucher <<a href="mailto:alexander.deucher@amd.com">alexander.deucher@amd.com</a>> > > --- > > drivers/gpu/drm/amd/amdgpu/mes_v12_0.c | 28 > > ++++++++++++++++++++++++++ > > 1 file changed, 28 insertions(+) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v12_0.c > > b/drivers/gpu/drm/amd/amdgpu/mes_v12_0.c > > index f9f2fbc0a7166..57d8b78210f9f 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/mes_v12_0.c > > +++ b/drivers/gpu/drm/amd/amdgpu/mes_v12_0.c > > @@ -879,6 +879,33 @@ static int mes_v12_0_reset_hw_queue(struct amdgpu_mes *mes, > > offsetof(union MESAPI__RESET, api_status)); > > } > > > > +static int mes_v12_0_set_gang_submit(struct amdgpu_mes *mes, > > + struct mes_set_gang_submit_input > > +*input) { > > + union MESAPI__SET_GANG_SUBMIT mes_gang_submit_pkt; > > + int pipe; > > + > > + memset(&mes_gang_submit_pkt, 0, sizeof(mes_gang_submit_pkt)); > > + > > + mes_gang_submit_pkt.header.type = MES_API_TYPE_SCHEDULER; > > + mes_gang_submit_pkt.header.opcode = MES_SCH_API_SET_GANG_SUBMIT; > > + mes_gang_submit_pkt.header.dwsize = API_FRAME_SIZE_IN_DWORDS; > > + > > + mes_gang_submit_pkt.set_gang_submit.gang_context_addr = > > + input->primary_gang_context_addr; > > + mes_gang_submit_pkt.set_gang_submit.slave_gang_context_addr = > > + input->secondary_gang_context_addr; > > + > > + if (mes->adev->enable_uni_mes) > > + pipe = AMDGPU_MES_KIQ_PIPE; > > + else > > + pipe = AMDGPU_MES_SCHED_PIPE; > > > > I think this packet should be always submitted to > > AMDGPU_MES_SCHED_PIPE, same pipe as in mes_v12_0_add_hw_queue where the queue is created. > > This is because HWS on AMDGPU_MES_KIQ_PIPE does not have the queue information. > > Sounds like the reset queue function and the map and unmap legacy queues should also be changed? > > Alex > > > > > + > > + return mes_v12_0_submit_pkt_and_poll_completion(mes, pipe, > > + &mes_gang_submit_pkt, sizeof(mes_gang_submit_pkt), > > + offsetof(union MESAPI__SET_GANG_SUBMIT, > > +api_status)); } > > + > > static const struct amdgpu_mes_funcs mes_v12_0_funcs = { > > .add_hw_queue = mes_v12_0_add_hw_queue, > > .remove_hw_queue = mes_v12_0_remove_hw_queue, @@ -888,6 > > +915,7 @@ static const struct amdgpu_mes_funcs mes_v12_0_funcs = { > > .resume_gang = mes_v12_0_resume_gang, > > .misc_op = mes_v12_0_misc_op, > > .reset_hw_queue = mes_v12_0_reset_hw_queue, > > + .set_gang_submit = mes_v12_0_set_gang_submit, > > }; > > > > static int mes_v12_0_allocate_ucode_buffer(struct amdgpu_device > > *adev, > > -- > > 2.49.0 > ><o:p></o:p> </div> </div> </div> </div> </div> </body> </html>