<div dir="ltr">Good morning Alex, I just resend the patch with the name I`ve been suggesting, please let me know if you have any recommendation. <div>And thanks again for your reply 😄 </div><div>Leonardo Gomes </div></div> <div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">Em sex., 16 de mai. de 2025 às 13:56, Alex Deucher <<a href="mailto:alexdeucher@gmail.com">alexdeucher@gmail.com</a>> escreveu: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Thu, May 15, 2025 at 9:23 PM Leonardo Gomes <<a href="mailto:leonardodasigomes@gmail.com" target="_blank">leonardodasigomes@gmail.com</a>> wrote: > > Thanks for your reply Alex, > > I just realize with your comment that drivers/gpu/drm/amd/display/dc/gpio/hw_gpio.c import dal_hw_gpio_get_value and dal_hw_gpio_set_value. > So to make those functions inside drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c more clear what do you think to change them to dal_hw_hpd_get_config and dal_hw_hpd_set_config, making clear that this is a function from the file hw_hpd? > Right. It needs a different name to avoid the conflict with the other function. Alex > Leonardo Gomes > > Em qua., 14 de mai. de 2025 às 18:08, Alex Deucher <<a href="mailto:alexdeucher@gmail.com" target="_blank">alexdeucher@gmail.com</a>> escreveu: >> >> On Wed, May 14, 2025 at 4:48 PM Leonardo Gomes >> <<a href="mailto:leonardodasigomes@gmail.com" target="_blank">leonardodasigomes@gmail.com</a>> wrote: >> > >> > Adjust get_value function in hw_hpd.c file to have >> > prefix to help in ftrace, the name change from >> > 'get_value' to 'dal_hw_gpio_get_value' >> >> This won't compile. dal_hw_gpio_get_value is already defined in >> drivers/gpu/drm/amd/display/dc/gpio/hw_gpio.c. >> >> Alex >> >> > >> > Signed-off-by: Leonardo da Silva Gomes <<a href="mailto:leonardodasigomes@gmail.com" target="_blank">leonardodasigomes@gmail.com</a>> >> > Co-developed-by: Derick Frias <<a href="mailto:derick.william.moraes@gmail.com" target="_blank">derick.william.moraes@gmail.com</a>> >> > Signed-off-by: Derick Frias <<a href="mailto:derick.william.moraes@gmail.com" target="_blank">derick.william.moraes@gmail.com</a>> >> > --- >> > drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c | 4 ++-- >> > 1 file changed, 2 insertions(+), 2 deletions(-) >> > >> > diff --git a/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c b/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c >> > index 3f13a744d07d..b11ed1089589 100644 >> > --- a/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c >> > +++ b/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c >> > @@ -62,7 +62,7 @@ static void dal_hw_hpd_destroy( >> > *ptr = NULL; >> > } >> > >> > -static enum gpio_result get_value( >> > +static enum gpio_result dal_hw_gpio_get_value( >> > const struct hw_gpio_pin *ptr, >> > uint32_t *value) >> > { >> > @@ -104,7 +104,7 @@ static enum gpio_result set_config( >> > static const struct hw_gpio_pin_funcs funcs = { >> > .destroy = dal_hw_hpd_destroy, >> > .open = dal_hw_gpio_open, >> > - .get_value = get_value, >> > + .get_value = dal_hw_gpio_get_value, >> > .set_value = dal_hw_gpio_set_value, >> > .set_config = set_config, >> > .change_mode = dal_hw_gpio_change_mode, >> > -- >> > 2.43.0 >> > </blockquote></div>