<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Calibri;font-size:10pt;color:#008000;margin:5pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left">
[Public]<br>
</p>
<br>
<div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
[Public]</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
With the change suggested by Harish below this patch looks good to me too.</div>
<div id="appendonsend" style="color: inherit;"></div>
<div class="elementToProof"><br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Reviewed-by: Alexandru Tudor <Alexandru.Tudor@amd.com></div>
<div class="elementToProof" style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<hr style="display: inline-block; width: 98%;">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<b>From:</b> Kasiviswanathan, Harish <Harish.Kasiviswanathan@amd.com><br>
<b>Sent:</b> Monday, May 26, 2025 1:48 PM<br>
<b>To:</b> Clement, Sunday <Sunday.Clement@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Tudor, Alexandru <Alexandru.Tudor@amd.com><br>
<b>Subject:</b> RE: [PATCH] drm/amdkfd: Identical code for different branches </div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: "Times New Roman"; font-size: 12pt;"><a name="BM_BEGIN"></a></div>
<div class="elementToProof" style="font-family: "Times New Roman"; font-size: 11pt;">
[Public]<br>
<br>
You can remove BUG:SWDEV-534537 from commit message as it doesn’t provide any information to public. With that this patch is<br>
<br>
Reviewed-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com.<br>
<br>
<br>
<br>
-----Original Message-----<br>
From: Clement, Sunday <Sunday.Clement@amd.com><br>
Sent: Friday, May 23, 2025 7:54 PM<br>
To: amd-gfx@lists.freedesktop.org<br>
Cc: Tudor, Alexandru <Alexandru.Tudor@amd.com>; Kasiviswanathan, Harish <Harish.Kasiviswanathan@amd.com>; Clement, Sunday <Sunday.Clement@amd.com><br>
Subject: [PATCH] drm/amdkfd: Identical code for different branches<br>
<br>
This patch removes the if/else statement in the<br>
cik_event_interrupt_wq function because it is redundant<br>
with both branches resulting in identical outcomes,<br>
this improves code readibility.<br>
<br>
BUG:SWDEV-534537<br>
<br>
Signed-off-by: Sunday Clement <Sunday.Clement@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c | 6 +-----<br>
1 file changed, 1 insertion(+), 5 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c b/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c<br>
index 981d9adcc5e1..25f32771b228 100644<br>
--- a/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c<br>
+++ b/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c<br>
@@ -125,11 +125,7 @@ static void cik_event_interrupt_wq(struct kfd_node *dev,<br>
return;<br>
}<br>
<br>
- if (info.vmid == vmid)<br>
- kfd_signal_vm_fault_event(pdd, &info, NULL);<br>
- else<br>
- kfd_signal_vm_fault_event(pdd, &info, NULL);<br>
-<br>
+ kfd_signal_vm_fault_event(pdd, &info, NULL);<br>
kfd_unref_process(p);<br>
}<br>
}<br>
--<br>
2.43.0<br>
<br>
</div>
</div>
</body>
</html>