<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Calibri;font-size:10pt;color:#0000FF;margin:5pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left">
[AMD Official Use Only - AMD Internal Distribution Only]<br>
</p>
<br>
<div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Hi Ursulin, Christian,</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
I find the upstream patch: <a href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=dd64956685fa48358c4152d952070c8c073e5f89" id="LPlnk654005">
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=dd64956685fa48358c4152d952070c8c073e5f89</a></div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
May I ask if I can modify the commit msg as:</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="margin-left: 40px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
drm/amdgpu: Fix memory leak in amdgpu_ctx_mgr_entity_fini</div>
<div class="elementToProof" style="margin-left: 40px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="margin-left: 40px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
patch "dd64956685fa drm/amdgpu: Remove duplicated "context still</div>
<div class="elementToProof" style="margin-left: 40px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
alive" check" removed ctx put, which will cause amdgpu_ctx_fini()</div>
<div class="elementToProof" style="margin-left: 40px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
cannot be called and then cause some finished fence that added by</div>
<div class="elementToProof" style="margin-left: 40px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
amdgpu_ctx_add_fence() cannot be released and cause memleak.</div>
<div class="elementToProof" style="margin-left: 40px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="margin-left: 40px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Fixes: dd64956685fa ("drm/amdgpu: Remove duplicated "context still alive" check")</div>
<div class="elementToProof" style="margin-left: 40px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
</div>
<div class="elementToProof" style="margin-left: 40px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Signed-off-by: Lin.Cao <lincao12@amd.com></div>
<div class="elementToProof" style="margin-left: 40px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com></div>
<div class="elementToProof" style="margin-left: 40px; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Acked-by: Christian König <christian.koenig@amd.com></div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Thanks,</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Lin</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Koenig, Christian <Christian.Koenig@amd.com><br>
<b>Sent:</b> Tuesday, June 24, 2025 21:11<br>
<b>To:</b> Tvrtko Ursulin <tursulin@ursulin.net>; cao, lin <lin.cao@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Chang, HaiJun <HaiJun.Chang@amd.com><br>
<b>Subject:</b> Re: [PATCH] drm/amdgpu: put ctx's ref count in amdgpu_ctx_mgr_entity_fini()</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">On 24.06.25 11:46, Tvrtko Ursulin wrote:<br>
> <br>
> On 24/06/2025 10:18, Lin.Cao wrote:<br>
>> patch "daf823f1d0cd drm/amdgpu: Remove duplicated "context still<br>
>> alive" check" removed ctx put, which will cause amdgpu_ctx_fini()<br>
>> cannot be called and then cause some finished fence that added by<br>
>> amdgpu_ctx_add_fence() cannot be released and cause memleak.<br>
> <br>
> Ouch I removed the wrong one. :( Probably misread kref_put as kref_read..<br>
> <br>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com><br>
<br>
Acked-by: Christian König <christian.koenig@amd.com><br>
<br>
> <br>
> But is the SHA correct? I see it is dd64956685fa.<br>
<br>
That could be because our internal branch is not yet rebased.<br>
<br>
> <br>
> Which would mean adding:<br>
> <br>
> Fixes: dd64956685fa ("drm/amdgpu: Remove duplicated "context still alive" check")<br>
<br>
And maybe CC stable? Or in which release is that patch upstream?<br>
<br>
Regards,<br>
Christian.<br>
<br>
> <br>
> Regards,<br>
> <br>
> Tvrtko<br>
> <br>
>> Signed-off-by: Lin.Cao <lincao12@amd.com><br>
>> ---<br>
>> drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 1 +<br>
>> 1 file changed, 1 insertion(+)<br>
>><br>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c<br>
>> index 85567d0d9545..f5d5c45ddc0d 100644<br>
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c<br>
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c<br>
>> @@ -944,6 +944,7 @@ static void amdgpu_ctx_mgr_entity_fini(struct amdgpu_ctx_mgr *mgr)<br>
>> drm_sched_entity_fini(entity);<br>
>> }<br>
>> }<br>
>> + kref_put(&ctx->refcount, amdgpu_ctx_fini);<br>
>> }<br>
>> }<br>
>> <br>
> <br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>