<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Calibri;font-size:10pt;color:#0000FF;margin:5pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left">
[AMD Official Use Only - AMD Internal Distribution Only]<br>
</p>
<br>
<div>
<pre><div class="elementToProof">one thing I noticed:
amdgpu_vcn_suspend() also gets called in vcn_v2_5_sw_fini() for example
where there isn't cancel_delayed_work_sync() call. Does the removal work in this case?</div></pre>
<span style="font-family: monospace;">David</span>
<div>On 8/20/2025 2:36 PM, Alex Deucher wrote:</div>
<blockquote>
<pre><div>Ping?
On Wed, Aug 13, 2025 at 3:37 PM Alex Deucher <a class="moz-txt-link-rfc2396E OWAAutoLink" id="OWA60db6a40-37a6-9538-6121-521085e745d9" href="mailto:alexander.deucher@amd.com"><alexander.deucher@amd.com></a> wrote:
</div></pre>
<blockquote>
<pre><div>We already call this in the hw_fini() methods for all
VCN instances, so no need to call it again in
amdgpu_vcn_suspend().
Signed-off-by: Alex Deucher <a class="moz-txt-link-rfc2396E OWAAutoLink" id="OWA56026710-eb02-5277-35c3-0eb9ee1432f5" href="mailto:alexander.deucher@amd.com"><alexander.deucher@amd.com></a>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
index 9a76e11d1c184..fd8ebf4b5a824 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
@@ -357,8 +357,6 @@ int amdgpu_vcn_suspend(struct amdgpu_device *adev, int i)
if (adev->vcn.harvest_config & (1 << i))
return 0;
- cancel_delayed_work_sync(&adev->vcn.inst[i].idle_work);
-
/* err_event_athub and dpc recovery will corrupt VCPU buffer, so we need to
* restore fw data and clear buffer in amdgpu_vcn_resume() */
if (in_ras_intr || adev->pcie_reset_ctx.in_link_reset)
--
2.50.1
</div></pre>
</blockquote>
</blockquote>
<br>
</div>
</body>
</html>