<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <p style="font-family:Calibri;font-size:10pt;color:#0000FF;margin:5pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left"> [AMD Official Use Only - AMD Internal Distribution Only]<br> </p> <br> <div> <div style="text-align: left; text-indent: 0px; background-color: rgb(255, 255, 255); margin: 0px; font-family: Calibri, Helvetica, sans-serif; font-size: 11pt; color: black;" class="elementToProof"> Hi Stanley, </div> <div style="text-align: left; text-indent: 0px; background-color: rgb(255, 255, 255); margin: 0px; font-family: Calibri, Helvetica, sans-serif; font-size: 11pt; color: black;" class="elementToProof"> Sure, will do, thanks.</div> <p style="text-align: left; text-indent: 0px; background-color: white; margin: 0px;" class="elementToProof"> <span style="font-family: Calibri, Helvetica, sans-serif; font-size: 11pt; color: black;">Regards,</span></p> <p style="text-align: left; text-indent: 0px; background-color: white; margin-top: 0px; margin-bottom: 0px;" class="elementToProof"> <span style="font-family: Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(36, 36, 36);">Liu, Xiang</span></p> <div id="appendonsend"></div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Yang, Stanley <Stanley.Yang@amd.com><br> <b>Sent:</b> Wednesday, August 20, 2025 3:28 PM<br> <b>To:</b> Liu, Xiang(Dean) <Xiang.Liu@amd.com>; Chai, Thomas <YiPeng.Chai@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br> <b>Cc:</b> Zhang, Hawking <Hawking.Zhang@amd.com>; Zhou1, Tao <Tao.Zhou1@amd.com><br> <b>Subject:</b> RE: [PATCH 2/2] drm/amdgpu: Check VF critical region before RAS poison injection</font> <div> </div> </div> <style>  </style> <div lang="EN-US" link="#467886" vlink="#96607D" style="word-wrap:break-word"> <p align="Left" style="font-family:Calibri; font-size:10pt; color:#0000FF; margin:5pt; font-style:normal; font-weight:normal; text-decoration:none"> [AMD Official Use Only - AMD Internal Distribution Only]<br> </p> <br> <div> <div class="x_WordSection1"> <p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black">All checking work should be done in host side, not only check current vf critical region but also other vf critical region.</span></p> <p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black">For example, in extreme cases, current row memory addresses may be in other vfs critical region, please handle this case in host side.</span></p> <p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black"> </span></p> <p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black">Regards,</span></p> <p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black">Stanley</span></p> <div style="border:none; border-left:solid blue 1.5pt; padding:0in 0in 0in 4.0pt"> <div> <div style="border:none; border-top:solid #E1E1E1 1.0pt; padding:3.0pt 0in 0in 0in"> <p class="x_MsoNormal"><b><span style="font-size:11.0pt; font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt; font-family:"Calibri",sans-serif"> Liu, Xiang(Dean) <Xiang.Liu@amd.com> <br> <b>Sent:</b> Wednesday, August 20, 2025 2:02 PM<br> <b>To:</b> Chai, Thomas <YiPeng.Chai@amd.com>; amd-gfx@lists.freedesktop.org<br> <b>Cc:</b> Zhang, Hawking <Hawking.Zhang@amd.com>; Zhou1, Tao <Tao.Zhou1@amd.com>; Yang, Stanley <Stanley.Yang@amd.com><br> <b>Subject:</b> Re: [PATCH 2/2] drm/amdgpu: Check VF critical region before RAS poison injection</span></p> </div> </div> <p class="x_MsoNormal"> </p> <p style="margin:5.0pt"><span style="font-size:10.0pt; font-family:"Calibri",sans-serif; color:blue">[AMD Official Use Only - AMD Internal Distribution Only]</span></p> <p class="x_MsoNormal"> </p> <div> <div> <p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black">Hi,</span></p> </div> <div> <p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black">As discuss offline with Thomas, will check the VF critical address regions of guest in another patch as a new feature.</span></p> </div> <p class="x_elementtoproof" style="background:white"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black">Regards,</span></p> <p class="x_elementtoproof" style="background:white"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#242424">Liu, Xiang</span></p> <div class="x_MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="x_divRplyFwdMsg"> <p class="x_MsoNormal"><b><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black">From:</span></b><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black"> amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">amd-gfx-bounces@lists.freedesktop.org</a>> on behalf of Liu, Xiang(Dean) <<a href="mailto:Xiang.Liu@amd.com">Xiang.Liu@amd.com</a>><br> <b>Sent:</b> Wednesday, August 20, 2025 1:33 PM<br> <b>To:</b> Chai, Thomas <<a href="mailto:YiPeng.Chai@amd.com">YiPeng.Chai@amd.com</a>>; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>><br> <b>Cc:</b> Zhang, Hawking <<a href="mailto:Hawking.Zhang@amd.com">Hawking.Zhang@amd.com</a>>; Zhou1, Tao <<a href="mailto:Tao.Zhou1@amd.com">Tao.Zhou1@amd.com</a>>; Yang, Stanley <<a href="mailto:Stanley.Yang@amd.com">Stanley.Yang@amd.com</a>><br> <b>Subject:</b> Re: [PATCH 2/2] drm/amdgpu: Check VF critical region before RAS poison injection</span> </p> <div> <p class="x_MsoNormal"> </p> </div> </div> <div> <p style="margin:5.0pt"><span style="font-size:10.0pt; font-family:"Calibri",sans-serif; color:blue">[AMD Official Use Only - AMD Internal Distribution Only]</span></p> <p class="x_MsoNormal"> </p> <div> <div> <p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black">Hi Thomas, </span></p> </div> <div> <p class="x_MsoNormal"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black">Sure, will do, thanks.</span></p> </div> <p class="x_xelementtoproof" style="background:white"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black">Regards,</span></p> <p class="x_xelementtoproof" style="background:white"><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:#242424">Liu, Xiang</span></p> <div class="x_MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="x_x_divRplyFwdMsg"> <p class="x_MsoNormal"><b><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black">From:</span></b><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black"> Chai, Thomas <<a href="mailto:YiPeng.Chai@amd.com">YiPeng.Chai@amd.com</a>><br> <b>Sent:</b> Wednesday, August 20, 2025 9:39 AM<br> <b>To:</b> Liu, Xiang(Dean) <<a href="mailto:Xiang.Liu@amd.com">Xiang.Liu@amd.com</a>>; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>><br> <b>Cc:</b> Zhang, Hawking <<a href="mailto:Hawking.Zhang@amd.com">Hawking.Zhang@amd.com</a>>; Zhou1, Tao <<a href="mailto:Tao.Zhou1@amd.com">Tao.Zhou1@amd.com</a>>; Yang, Stanley <<a href="mailto:Stanley.Yang@amd.com">Stanley.Yang@amd.com</a>><br> <b>Subject:</b> RE: [PATCH 2/2] drm/amdgpu: Check VF critical region before RAS poison injection</span> </p> <div> <p class="x_MsoNormal"> </p> </div> </div> <div> <div> <p class="x_MsoNormal" style="margin-bottom:12.0pt"><a name="x_x_BM_BEGIN"></a><span style="font-size:11.0pt; font-family:"Times New Roman",serif">[AMD Official Use Only - AMD Internal Distribution Only]<br> <br> -----Original Message-----<br> From: Liu, Xiang(Dean) <<a href="mailto:Xiang.Liu@amd.com">Xiang.Liu@amd.com</a>><br> Sent: Tuesday, August 19, 2025 1:26 PM<br> To: <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br> Cc: Zhang, Hawking <<a href="mailto:Hawking.Zhang@amd.com">Hawking.Zhang@amd.com</a>>; Zhou1, Tao <<a href="mailto:Tao.Zhou1@amd.com">Tao.Zhou1@amd.com</a>>; Yang, Stanley <<a href="mailto:Stanley.Yang@amd.com">Stanley.Yang@amd.com</a>>; Chai, Thomas <<a href="mailto:YiPeng.Chai@amd.com">YiPeng.Chai@amd.com</a>>; Liu, Xiang(Dean) <<a href="mailto:Xiang.Liu@amd.com">Xiang.Liu@amd.com</a>><br> Subject: [PATCH 2/2] drm/amdgpu: Check VF critical region before RAS poison injection<br> <br> Check VF critical region before RAS poison injection to ensure that the poison injection will not hit the VF critical region.<br> <br> Signed-off-by: Xiang Liu <<a href="mailto:xiang.liu@amd.com">xiang.liu@amd.com</a>><br> ---<br> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 7 +++++++<br> 1 file changed, 7 insertions(+)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c<br> index b00cbb927ca8..6730de574fdc 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c<br> @@ -219,10 +219,17 @@ static int amdgpu_check_address_validity(struct amdgpu_device *adev,<br> struct amdgpu_vram_block_info blk_info;<br> uint64_t page_pfns[32] = {0};<br> int i, ret, count;<br> + bool hit = false;<br> <br> if (amdgpu_ip_version(adev, UMC_HWIP, 0) < IP_VERSION(12, 0, 0))<br> return 0;<br> <br> + if (amdgpu_sriov_vf(adev)) {<br> + if (amdgpu_virt_check_vf_critical_region(adev, address, &hit))<br> + return -EPERM;<br> + return hit ? -EACCES : 0;<br> <br> [Thomas]Only checking if the address is within the PF critical address regions may be not sufficient,<br> The VF critical address regions of guest may be also need to be checked.<br> <br> + }<br> +<br> if ((address >= adev->gmc.mc_vram_size) ||<br> (address >= RAS_UMC_INJECT_ADDR_LIMIT))<br> return -EFAULT;<br> --<br> 2.34.1</span><span style="font-family:"Times New Roman",serif"></span></p> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </body> </html>