[PATCH] tracedump: add --help and --function-histogram

[José Fonseca]

On Thu, Oct 20, 2011 at 5:24 PM, Carl Worth <cworth at cworth.org> wrote:
> On Thu, 20 Oct 2011 15:58:18 +0200, José Fonseca <jose.r.fonseca at gmail.com> wrote:
>> Portability fixes will be needed as you admited, talloc dependency
>> removed as Zack mentioned, but implementation details apart, this is
>> the direction I'd like to take. So thanks for taking the initiative.
>
> You're quite welcome. For portability, I will need more specific
> guidance on what the other platforms need. So I'll wait to hear details,
> (which can probably wait until I have a closer-to-ready breanch).

The first hurdle is just getting things to build on the other two
supported platforms, i.e MacOSX and Windows. Apart of the GUI, MacOSX
is pretty much similar to Linux. Windows is a more different beast.
You should install mingw32 cross-compilers if you wanna write win32
portable code yourself.

Of course, the actual implementation of "apitrace trace" command for
MacOSX and Win32 will differ, but this is not something that needs to
work from the start given it is a new feature and not a regression,
i.e., it is fine to have "apitrace trace" to say "unsupported
platform" for windows and MacOSX and defer the implementation to after
the merge.

>> I'd prefer that you work on a branch on the main apitrace repos, so
>> that I can also collaborate, in particular non-Linux OS portability
>> fixes.  Do you have a github account?
>
> I'm glad to work pretty much anywhere, but what difference does it make
> which repository the branch is in? If you do:
>
>        git remote add cworth git://git.cworth.org/git/apitrace
>
> Then you can just do:
>
>        git remote update
>
> to update your code, (from both the upstream as well as my repository),
> and it should be every bit as easy as if my branch lived in the same
> repository. About the only difference is that my branch would be named
> cworth/master rather than some other name. (And I can start using names
> other than just "master" if I focus branches on specific topics.)

I can manage multiple repos easily. But can I push to
git://git.cworth.org/git/apitrace as well? I really don't wanna use
email for trivial things such as obvious bug fixes, or build fixes.

For me the process that works the best is:
1. you/somebody makes a branch with a feature
2. you get the code to a point where it works minimailly
3. you tell me it's ready for me to look at
4. I review the code, I test on all platforms, and commit build fixes,
trivial bugfixes, etc. to the feature branch
5. I may ask to do some further changes (e.g., fix regressions) which
take us back to step 2
6. I merge the branch into master, and delete the feature branch

It's important to realize that by the time the branch is merged no
feature should regress on any of the platforms.

Jose