[PATCH] tracedump: Add tri-state --color option (auto, always, or never)

José Fonseca jose.r.fonseca at gmail.com
Tue Oct 25 15:00:30 PDT 2011


On Tue, Oct 25, 2011 at 8:36 PM, Zack Rusin <zack at kde.org> wrote:
> On Tuesday, October 25, 2011 02:26:37 PM José Fonseca wrote:
>> Zack added an .emacs-dirvars, but .emacs-dirvars looks to be more
>> non-standard compared to .dir-locals.el, which is supported by emacs
>> out of the box I believe.
>
> I've been using emacs for a very long time and there was no such thing as dir-
> locals when i start but dirvars.el was a package so I was using it. A while
> back I've seen in the emacs news file something mentioned about that
> functionality but i never cared enough to follow up on account of dirvars
> working ok.
>
> If .dir-locals.el can replicate what dirvars does, then lets just insert that
> into the repo and remove dirvars.

Sounds good to me. I'll do so.

>> What does c-file-style "linux" achieve?
>
> It's one of the builtins c/c++ styles for emacs, approximating the linux
> kernel style. In this case it's rather wrong, because as far as emacs
> definitions go we're closer to what emacs calls bsd style not linux style but


> you should probably define the style you like and add a short blurb about it.
> Also the variable/method/function naming is starting to get confusing
> (camelCase or under_scores).

Excellent point.  Due to mesa / gallium / python influence I started
with under_scores here, but GL/D3D all use camelCase, so the later is
a better fit and that's what I've been sticking with for new code.
I'll write up a document with the desired style convention soon.

Jose


More information about the apitrace mailing list