[PATCH] tracedump: Add tri-state --color option (auto, always, or never)

José Fonseca jose.r.fonseca at gmail.com
Mon Oct 31 08:56:03 PDT 2011


On Sat, Oct 29, 2011 at 1:23 AM, Carl Worth <cworth at cworth.org> wrote:
> On Tue, 25 Oct 2011 19:26:37 +0100, José Fonseca <jose.r.fonseca at gmail.com> wrote:
>> Looks good to me. I agree that tackling the low hanging fruit first is
>> best.
>
> Great. I think that as soon as we're past these first few hurdles, the
> rest of the new command-line interface will fall into place quickly.
>
>> Just one request, please put each command on its separate .cpp file
>> (e.g., apitrace_dump), leaving apitrace.{cpp,hpp} for stuff shared by
>> all of them.
>>
>> Furthermore, let's put all the command line commands in a "cli"
>> subdirectory, and put piece of functionality which can be shared with
>> the gui in a library -- maybe "common" for the time being.
>
> These two are done now in a new "cli" branch in my repository, (I also
> fixed "command_t" to now be "Command").
>
> I see your os-path branch and will now build on top of that to implement
> "apitrace trace" as well as doing external invocation for other commands
> that already exist as scripts.

Carl,

I've merged the tracedump changesfrom cli branch into master. I've
refactored the code around a bit to keep each command isolated, but
just trivial stuff.

I've also merged the os-path.

So please rebase on master.

Jose


More information about the apitrace mailing list