[PATCH 0/2] Capture and display frame thumbnails in qapitrace. (Pass 2)

[Dan McCabe]

On 03/21/2012 01:53 PM, Dan McCabe wrote:
> On 03/11/2012 07:36 AM, José Fonseca wrote:
>> On Tue, Mar 6, 2012 at 1:20 AM, Dan McCabe<zen3d.linux at gmail.com>  
>> wrote:
>>> This patch set automatically captures and displays thumbnails for each
>>> frame in qapitrace.
>>>
>>> 2) Testing for going past end of QList in bindThumbnailsToFrames. This
>>> should eliminate asset failures that Jose encountered (but which I 
>>> never
>>> saw).
>> Dan, I'm now seeing a slightly different assertion failure:
>>
>> ASSERT failure in QList<T>::operator[]: "index out of range", file
>> /usr/include/qt4/QtCore/qlist.h, line 460
>>
>> I don't have time to debug this myself right now. But from the looks
>> of it, I get the feeling that glretrace is being invoked before the
>> trace is fully scanned.
>>
>> Jose
>
> Hi Jose,
>
> I will also make the failure handling code in retracer.cpp more robust.
>
> Thanks.
>
> cheers, danm
>
>

Or not.

It's not obvious to me why the error handler in retracer.cpp fails 
without being able to reproduce this issue.

Basically, lines of error messsages are matched to a regular expression. 
When matches are found, ApiTraceError objects are enqueued in a list.

Apparently, one or matches of the format desired do occur, apprently 
capturing some sort of callIndex (that is too large perhaps?).

The error handling doesn't look unreasonable under the circumstances.

However, in the absence of my actually seeing this error, all I can do 
is speculate and conjecture. I'm reluctant to write code that I can't test.

cheers, danm