[PATCH] egltrace/android: Fix tracing Zygote processes (v2)

Alexander Monakov amonakov at ispras.ru
Fri Jun 7 02:37:03 PDT 2013



On Thu, 6 Jun 2013, Chad Versace wrote:
> Not only is the call to trimDirectory() unnecessary,

Agreed, but ...

> it also returns garbage when there is no path separator.

no, this doesn't sound right.  Inspection of os::String::trimDirectory does
not suggest anything like that might be possible: if there is no path
separator in the string, rfindSep() returns end() and trimDirectory leaves the
string untouched.  FWIW, previous Android users have not seen this problem.

I guess the patch is fine, but it would be papering over a bigger issue.

Alexander


More information about the apitrace mailing list