[PATCH] Add glretrace option '--snapshot-format=MD5' that allow write image MD5 to a text format file.

Alexander Monakov amonakov at ispras.ru
Tue Oct 29 14:39:30 CET 2013


Hi,

It would be nice if you explained the motivation for this change.  Presumably
this is for improving speed of verification that rendering results are 100%
reproducible.

If that is true, your choice of hash algorithm is questionable.  Consider that
bandwidth of RGBA 1920x1080 at 60 fps stream is about 0.5 GB/s.  I'm not certain
that md5 implementation you're importing can hash at that speed.  Even if it
can, using MD5 and importing a library definitely seems like an overkill.

Surely you can do with a much simpler and faster (but weaker) hash that would
not require importing yet another library into thirdparty/?

Thanks.
Alexander


More information about the apitrace mailing list