[AppStream] Putting review data into AppStream

[Richard Hughes]

On 20 July 2016 at 09:29, Matthias Klumpp <matthias at tenstral.net> wrote:
> Is there an upper (or lower) limit? Past which value is the review "useful"?

Well, you get +1 karma for each positive click, so a int32 should be
just fine :)

> IMHO that wouldn't make too much sense, especially since we can just
> add the same review translated to a different language...

Right.

> So, a <lang/> or <language/> tag makes sense to me here. (complex
> translation logic is also not useful in a web-server context, where I
> guess we just request the reviews for a specific language anyway)

Sure. The language code also means some more things, e.g. gnome-maps
might work fine in England but not work in Somalia, so it doesn't make
sense to translate the en_GB translation for all countries.

>> <reviews>
>>   <review id="3045" karma="35" date="2016-07-01" rating_percent="80">
>
> This would make it a review-id, not a reviewer-id. This looks like a
> unique identifier for the particular review, rather than one for the
> particular reviewer.

So, we probably need both :)

> <reviews>
>   <review karma="35" date="2016-07-01" rating_percent="80" xml:lang="en_GB">

So, two things:

* rating_percent seems quite verbose. Maybe just "percent"?
* xml:lang isn't designed to be used on the parent tag; only on the
tag that's translated (as I understand it). I think using
<lang>en_GB</lang> is probably best here.

>     <reviewer_name>Richard Hughes</reviewer_name>
>     <reviewer_id>3045</reviewer_id>

Looks good to me.

Richard.