[AppStream] Adding <filename> to <artifact>?

Richard Hughes hughsient at gmail.com
Thu Jan 28 15:59:47 UTC 2021


On Thu, 28 Jan 2021 at 15:55, Matthias Klumpp <matthias at tenstral.net> wrote:
> Two questions: Why do you need a filename at all for a cache? Wouldn't
> just using any of the checksums be enough?

I guess just user experience; I'm guessing users would feel more
comfortable doing:

fwupdmgr install hughski-colorhug2-1.2.5.cab

rather than

fwupdmg install QmfHhw3LewHVFi13f839yXWsBG8UHu1AaAvWQcSAVjHUXn

> And second: Why does the filename contain something like a hash
> already? Shouldn't it be
> <filename>hughski-colorhug2-1.2.5.cab</filename> with any "make it
> unique" hashes appended by the caching code on the client side, rather
> than trusting a value in the metainfo file?

Hmm, that's an artifact of the LVFS -- I guess we should remove the
hash in the filename.

> Hehe ^^ - I think adding <filename/> is reasonable

So, should I start using <filename> already? :)

Richard.


More information about the AppStream mailing list