[Authentication] Small API issues

[Stef Walter]

Michael Leupold wrote:
> On Wednesday 15 July 2009 19:06:51 Stef Walter wrote:
>> Michael Leupold wrote:
>>> - org.freedesktop.Secrets.Session.Negotiate should get an argument OUT
>>> bool successful
>> Yes, or a tristate: continue = -1, success = 1, failure = 0
> 
> I'm not sure what "continue" is there for but if you think this is useful with 
> certain negotiation protocols I'm ok with it.

Yes certain key negotiaton protocols go back and forth more than once.
So it'd be nice not to limit this future possibility.

>>> 3. Object paths:
>>> - Object paths could be shorter. I'd advocate /<apiname> (eg.
>>> /Secrets/...) effectively stripping the /org/freedesktop prefix.
>> Are you sure that's the right way to do things? Object paths are global
>> to the dbus bus, and should have a unique prefix.
> 
> As I understand it object paths are local to the service name. From what I see 
> in other protocols some seem to use /org/freedesktop while others use 
> /Servicename.

Interesting. Which services do that?

>>> 4. Errors:
>>> - add org.freedesktop.Secrets.Error.NoSession for methods calls which
>>> require a session but have none
>> Very likely a good idea, but let's add errors as we need them. Which
>> methods would return this? If you list them I'll it to the documentation.
> 
> I'd put that on Service.SearchItems and Service.RetrieveSecrets as the service 
> interface will be available even if no session exists.

True for Service.RetrieveSecrets(). But an application can search for
items even when no session exists.

Cheers,

Stef