[avahi] Werror patch

Lennart Poettering lennart at poettering.de
Wed Aug 3 10:02:56 EST 2005

On Wed, 03.08.05 00:33, Ikke (eikke at eikke.com) wrote:

> Hija,
> attached you can find a little patch to add -Werror to the build process
> (which can be a good thing, as right now, sometimes things like function
> callback prototypes are wrong in the tests). There are some problems
> with DBUS-enabled parts, as there is some stuff in the DBUS headers
> -pedantic doesnt like (; outside function bodies). This should be fixed
> in the DBUS distribution, I might make a patch for that.
> Latest revision 210 builds with it, normally.

Hmm, I am reluctant to merge this, since some gcc versions warn about
some things where others do not. If we add this option unconditionally
the build might break for some users which do not run the same gcc
version as we do.

I you make this an option for ./configure I'd welcome the patch,
though. If you do this you might consider adding the parameters named
at the bottom of http://mces.blogspot.com/2005/07/char-const-argv.html
at the same time. (this isn't trivial since not all of them are
available on all gcc version. e.g. my gcc 3.3 doesn't accept -Wextra)

I merged the other changes.

Thank you, 

Lennart Poettering; lennart [at] poettering [dot] de
ICQ# 11060553; GPG 0x1A015CC4; http://0pointer.de/lennart/

More information about the avahi mailing list