[avahi] pygtk

[Lennart Poettering]

On Thu, 04.08.05 09:13, Trent Lloyd (lathiat at bur.st) wrote:

> Why does the build require the dev files for pygtk? afaict they arent
> required as everything builds fine without it except the ./configure
> whinges 
> 
> An alternate method of determining whatever it wants to know could be
> better?

Related to this:

Sebastien, you broke my build! I have a server without python
installed, in r217 I fixed the build to not require python. But now
you broke it again.

You replaced the following lines:

AM_PATH_PYTHON(2.4, [HAVE_PYTHON=yes], [HAVE_PYTHON=no])
AM_CONDITIONAL(HAVE_PYTHON, [test "x$HAVE_PYTHON" = xyes ])

(requires automake 1.9, sorry)

with:

AM_PATH_PYTHON(2.4)
AM_PYTHON_CHECK_VERSION("$PYTHON", 2.4, [HAVE_PYTHON=yes], [HAVE_PYTHON=no])
AM_CONDITIONAL(HAVE_PYTHON, [test "x$HAVE_PYTHON" = xyes ])

Which is smotheing completely different.

Please fix this ASAP! For the time being I disabled your pygtk stuff,
because it even prevented my to buld avahi on my PC.

I don't think that autoconf tests for pygtk/glade make any sense
here. I like the way the bittorrent packages handle this: don't
require pygtk/glade for build but print out a nice message when you
run the tools that if you want to make use of the GUI you need to
install pygtk. i.e. change avahi-discover to import pygtk like this:

try:
       import gtk, gobject
except ImportError, e:
       print "Sorry, you need to install pygtk to use this tool."
       sys.exit(2)

BTW, I have another suggestion for you how to improve
avahi-discover. Add another tree level for the network a service is
found on, and drop the column showing this instead. An example:

+ Interface eth0 (IPv4)
  + Domain .local
    + Service Type _http._tcp
      + Web Service #1
      + Blah Blubb
    + Type _ftp._tcp
      + My FTP Server
  + Domain .home
    + Service Type _presence._tcp
      + Lieschen Müller
      + Peter Panther
+ Interface wlan0 (IPv4)
  + Domain .local
    + Service Type _http._tcp
      + Miau
+ Interface wlan0 (IPv6)
  + Domain .local
    + Service Type _gurki._tcp
      + Brrrumm!

And expanding the entries in the tree view by default would be cool,
too.

And finally: clicking on any of the entries doesn't reveal any
information at the moment. This worked some revisions ago, but doesn't any more?

BTW: I changed the Makefile.am in avahi-utils to replace @PYTHON@ and
friends using sed instead of using autoconf. Somewhere in the autoconf
they suggest that paths shouldn't be replaced by autoconf but only by
make.

Thanks,
        Lennart

-- 
Lennart Poettering; lennart [at] poettering [dot] de
ICQ# 11060553; GPG 0x1A015CC4; http://0pointer.de/lennart/