[avahi] [patch] SUSE initscript

[Trent Lloyd]

On Fri, Jul 01, 2005 at 01:53:13PM -0400, Joe Shaw wrote:
> Hi,
> 
> Attached is a patch which adds an initscript for SUSE.

I've taken a look at your patch.

Looks good other than avahi has its own internal machanism for handling
reloads and stops (You can see the debian init script for an example).

It would be preferable for the suse init script to use these.

Essentially:
Start:
$AVAHI_BIN -D

Stop:
$AVAHI_BIN -k

Reload:
$AVAHI_BIN -r

Is there a problem with this in relation to suse or would having your
init script use these not be a problem?

Cheers,
Trent

> 
> Joe

> Index: initscript/SUSE/avahi
> ===================================================================
> --- initscript/SUSE/avahi	(revision 0)
> +++ initscript/SUSE/avahi	(revision 0)
> @@ -0,0 +1,47 @@
> +#! /bin/sh
> +### BEGIN INIT INFO
> +# Provides:       avahi
> +# Required-Start: $network dbus
> +# Default-Start:  3 5
> +# Default-Stop:
> +# Description: Avahi, a ZeroConf daemon for mDNS and service registration
> +### END INIT INFO
> +
> +AVAHI_BIN=/usr/bin/avahi
> +test -x $AVAHI_BIN || exit 5
> +
> +. /etc/rc.status
> +rc_reset
> +
> +case "$1" in
> +    start)
> +        echo -n "Starting Avahi daemon"
> +        startproc $AVAHI_BIN -D
> +	rc_status -v
> +        ;;
> +    stop)
> +        echo -n "Shutting down Avahi daemon"
> +        killproc -TERM $AVAHI_BIN
> +	rc_status -v
> +        ;;
> +    restart)
> +        $0 stop
> +        $0 start
> +	rc_status
> +        ;;
> +    force-reload|reload)
> +        echo -n "Reloading Avahi daemon"
> +        killproc -HUP $AVAHI_BIN
> +	rc_status -v
> +        ;;
> +    status)
> +        echo -n "Checking for Avahi daemon: "
> +        checkproc $AVAHI_BIN
> +        rc_status -v
> +        ;;
> +    *)
> +        echo "Usage: $0 {start|stop|status|restart|force-reload|reload}"
> +        exit 1
> +        ;;
> +esac
> +
> 
> Property changes on: initscript/SUSE/avahi
> ___________________________________________________________________
> Name: svn:executable
>    + *
> 
> Index: initscript/SUSE/Makefile.am
> ===================================================================
> --- initscript/SUSE/Makefile.am	(revision 0)
> +++ initscript/SUSE/Makefile.am	(revision 0)
> @@ -0,0 +1,4 @@
> +initddir = $(sysconfdir)/init.d
> +initd_SCRIPTS = avahi
> +
> +EXTRA_DIST = $(initd_SCRIPTS)
> Index: configure.ac
> ===================================================================
> --- configure.ac	(revision 159)
> +++ configure.ac	(working copy)
> @@ -185,7 +185,7 @@
>     exit 1
>  else
>  case $with_distro in
> -   debian|gentoo)
> +   debian|gentoo|suse)
>       ;;
>     *)
>       echo "Your distribution (${with_distro}) is not yet supported!  (patches welcome)"
> @@ -243,6 +243,7 @@
>  initscript/Makefile 
>  initscript/Debian/Makefile
>  initscript/Gentoo/Makefile
> +initscript/SUSE/Makefile
>  avahi-dnsconfd/Makefile
>  ])
>  AC_OUTPUT

> _______________________________________________
> avahi mailing list
> avahi at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/avahi


-- 
Trent Lloyd <lathiat at bur.st>
Bur.st Networking Inc.