[avahi] [PATCH] make building with --disable-static and DBUS work

[Lennart Poettering]

On Thu, 24.11.05 01:33, Nix (nix at esperi.org.uk) wrote:

> Right now (well, as of Avahi 0.6), avahi's building two libraries for
> libdbus-common; one with -fPIC enabled and one not. It's building both
> of these with --all-static in an apparent attempt to force a convenience
> library build.
> 
> However, that's not what --all-static does; you end up with a library
> which when --disable-static is specified is *empty*, so avahi-daemon and
> avahi-client fail to build.

Mmm, I don't understand why the library is empty in that case. Please
exlain. Honestly, I never tried to compile avahi statically, so I
don't have much experience with this.

> This patch fixes that, ditches the mostly useless no-fpic version (who
> cares if a tiny bit of rarely-executed code in a root daemon is PIC?
> Most distributors these days will build network-exposed daemons such as
> Avahi as position-independent executables anyway) and renames the
> libraries to something more obviously Avahiish. (You might not want the
> latter; I did it out of paranoia in case my changes led to the library
> somehow being installed ;) )

Some minutes ago i commited r1028 to SVN which contains a different
fix for this. Instead of building a static library of these two files
i added them directly to the _SOURCES list of the binaries that need
them. This is much simpler and doesn't build with -fPIC unless it is
needed.

Unless this doesn't work for your I will release this as Avahi 0.6.1
tomorrow.

> (as an aside, it would be nice if there were some way to email patches
> like this without first having to subscribe to a mailing list. This is
> the only piece of free software I've ever used that doesn't have *some*
> non-subscription email contact address for patches and the like. Even
> the rejection message is unfriendly, saying that I am `not allowed' to
> send messages to the list, but not saying that this is because I'm not
> subscribed...)

You're welcome to do manual spam filtering for us! 

fd.o doesn't run a spam filter (as it seems), hence we disabled postings
from non-members simply because the volume of bogus moderation requests
exceeded what we could handle.

Lennart

-- 
Lennart Poettering; lennart [at] poettering [dot] de
ICQ# 11060553; GPG 0x1A015CC4; http://0pointer.de/lennart/