[avahi] [PATCH] [RFC] Untested interface limitation patch

[Stefan de Konink]

Hey,


On Sun, 11 May 2008, Lennart Poettering wrote:

 > > I am confused.

Nvm, ffmpeg-devel insiders joke.

 >> > > This patch tries to accomplish to limit the used interfaces 
based on a user
 >> > > defined list in the daemon configuration file. The idea would be 
if the
 >> > > list is not defined, it will just process every found interface, 
if the
 >> > > list is present, it will iterate over the list for every found 
interface. A
 >> > > todo is clean the list from duplicates.
 > >
 > > I am mostly happy for the patch. Before I'll merge I'd however ask
 > > you to rename the option to something to "interface-allow" or
 > > "allow-interfaces" or so. I'd consider "bind-interfaces" misleading,
 > > since this suggests that some kind of bind() is involved here, which
 > > however is not the case.
 > >
 > > I'd prefer if we'd also get an interface blacklist at the same time
 > > as a whitelist, but that wouldn't hinder me to merge your
 > > patch. (i.e. "deny-interfaces" would be cool in addition to
 > > "allow-interface").

I'll do this too then. Since it is the same function. What would be the
resolve scenario? First deny then allow?


 >> > > -int avahi_interface_is_relevant(AvahiInterface *i) {
 >> > > +static int avahi_interface_is_relevant_iter(AvahiInterface *i) {
 > >
 > > Hmm, why did you call this "_iter"? I see no iterator involved here */

Basically because of the function under it. Any good hints? _static,
_private, _child?

 >> > >      AvahiInterfaceAddress *a;
 >> > >
 >> > > -    assert(i);
 >> > > +    assert(i); // Not really required
 > >
 > > Hehe, *no* assert is really required.

It is already done by its parent. (The function under it that was 
actually the added code, and nobody should call this static one anyway)

 > > Also /me doesn't like C++ style
 > > comments. So please leave this as it is right now. /me likes
 > > paranoid asserts.
 > >
 > > /* This is C */
 > >
 > > // this is C++

As you wish  ;)


 > > Hmm, avahi_server_config_free() needs updating, too.
 > >
 > > And finally, man/avahi-daemon.conf.5.xml.in and
 > > avahi-daemon/avahi-daemon.conf need updating as well.

I guess I missed that  :)

 > > Otherwise I am happy, no further nitpicking  ;-)

Since nobody tested the patch on working I hope you will volunteer  ;)

 > > Thanks for your patch!

You're welcome. A little nitpicking on my own... in my private network 
at home I get very annoyed by Avahi just guessing my SSH port is at 22, 
would it be possible to check this before advertising?


Yours Sincerely,

Stefan de Konink