[avahi] [PATCH] Fixes for lfs initscripts

[Lennart Poettering]

On Tue, 14.04.09 14:57, William Immendorf (will.immendorf at gmail.com) wrote:

> 
> On Tue, Apr 14, 2009 at 2:31 PM, Lennart Poettering
> <lennart at poettering.net> wrote:
> > On Mon, 06.04.09 09:41, William Immendorf (will.immendorf at gmail.com) wrote:
> >> 1. I didn't use a sed to redict the .in file to a bootscript because
> >> there was nothing to sed. However, this causes chown to fail because it
> >> cant find the 'avahi' bootscript. I fixed that in the patch by adding a
> >> cat to redict the .in file to the bootscript itself.
> >
> > Uh. It would make more sense if the init script would start the daemon
> > via the right path.

> Echg, you don't know how loadproc from the LFS initscripts works: It
> automaticaly finds the daemon to start, so seding is not necessary.

Fine. Most real world distro's tend to prefer absolute paths to avoid
the needless stat()s. 

Anyway, if no rewriten is necessary, then please remove the rewriting
entirely. No 'cat foo.in > foo' please. That's nonsense.

> >> 2. And also, I forgot to make symlinks to the bootscript in the
> >> makefile, because that is what LFS does. So I added the ln commands to
> >> make the symlinks.
> >
> > We dn't create those link farms on any distribution. Activating init
> > services is a job for the administrator, not for 'make install'.

> You don't know how LFS initscripts are layed out. The main init script
> is installed into /etc/rc.d/init.d, and symbolic links are created in
> /etc/rc.d/rc{0,1,2,3,4,5,6,sysinit}.d dirs. The form they are in is
> this:
> 
> {Either S for start, or K for kill}{number that decinisates when the
> script will run}{bootscript name}

Yes, that's classic SysV init. Like almost every distro still does
it. And we don't create those link farms on any distro.

> Oh, and why is this in make install? Because it would be a hassale for
> the sysadmin to create those symbolic links manualy.

Sure. But that's why folks invented package managers. We don't create
those symlinks for any distro because creating those links is a job
for a package manager, not for install scripts.

Also, creating those links manually is almost certainly wrong. Every
distro has a tool that manages that automatically for you.

Also, I thought the point of LFS was to do everything manually, wasn't
it? 

Lennart

-- 
Lennart Poettering                        Red Hat, Inc.
lennart [at] poettering [dot] net         ICQ# 11060553
http://0pointer.net/lennart/           GnuPG 0x1A015CC4