[avahi] [patch] add aliases configuration setting to register CNAME records

Stijn Hoop stijn at sandcat.nl
Wed Aug 1 07:48:16 PDT 2012


On Wed, 1 Aug 2012 13:40:36 +0200
Markus Rathgeb <maggu2810 at googlemail.com> wrote:

> Just two comments:
> 
> avahi-core/entry.c line 454:
> memory leak: If you return on error because avahi_record_new_full
> failed, fq will not be freed.
> 
> avahi-daemon/cnames.c line 78:
> I do not know what is the common usage in the avahi sources, but I
> would prefer to add a default case to a switch statement.
> You should also add a break on the last cases. It will prevent errors
> if you add other cases later.

Thanks, revised patch attached.

--Stijn
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-capability-to-present-aliases-for-the-host-as-CN.patch
Type: text/x-patch
Size: 14721 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/avahi/attachments/20120801/70e5d79f/attachment-0001.bin>


More information about the avahi mailing list